Skip to content

[lldb] Enable a test that was never enabled #83925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

felipepiovezan
Copy link
Contributor

According to the git log (d9442af), this test has never been enabled/disabled, it was checked in without being called anywhere. But it passes and it is useful, so this commit enables it.

According to the git log (d9442af), this test has never been
enabled/disabled, it was checked in without being called anywhere. But it passes
and it is useful, so this commit enables it.
@llvmbot
Copy link
Member

llvmbot commented Mar 4, 2024

@llvm/pr-subscribers-lldb

Author: Felipe de Azevedo Piovezan (felipepiovezan)

Changes

According to the git log (d9442af), this test has never been enabled/disabled, it was checked in without being called anywhere. But it passes and it is useful, so this commit enables it.


Full diff: https://github.com/llvm/llvm-project/pull/83925.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py (+1)
diff --git a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
index b2c9551eda6acb..129290909029a1 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
@@ -13,6 +13,7 @@ def test(self):
         """Test breakpoint command for different options."""
         self.build()
         self.breakpoint_options_test()
+        self.breakpoint_options_language_test()
 
     def setUp(self):
         # Call super's setUp().

@felipepiovezan
Copy link
Contributor Author

felipepiovezan commented Mar 4, 2024

@JDevlieghere I believe you were the last one to touch this test, so I'll let you review this :D

@felipepiovezan felipepiovezan merged commit 488ac3d into llvm:main Mar 4, 2024
@felipepiovezan felipepiovezan deleted the felipe/enable_test branch March 4, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants