[OpenMP] Sort topology after adding processor group layer. #83943
Conversation
Various behavior around creating affinity masks and detecting uniform topology depends on the topology being sorted. resort topology after adding processor group layer to ensure that the updated topology reflects the newly added processor group info. Observed that the topology was not sorted correctly on high core count AMD Epyc Genoa (2 sockets, 96 cores, 2 threads) using NUMA (NPS 2+).
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@jpeyton52 Is this something you could review + approve and/or look at ? The current behavior ends up, unintentionally I think, creating default affinity masks that are smaller than a proc group when running on a NUMA topology with 2 or mores nodes (NPS 2+). |
|
@jpeyton52 I don't have write access to the repo; can you merge this PR or do I need to do something? |
|
@MessyHack Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Various behavior around creating affinity masks and detecting uniform topology depends on the topology being sorted.
resort topology after adding processor group layer to ensure that the updated topology reflects the newly added processor group info.
Observed that the topology was not sorted correctly on high core count AMD Epyc Genoa (2 sockets, 96 cores, 2 threads) using NUMA (NPS 2+).