Skip to content

[bzl] Remove obsolete output_to_genfiles = True #83944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[bzl] Remove obsolete output_to_genfiles = True #83944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,5 @@ enum_targets_gen = rule(
" `@LLVM_ENUM_{macro_name}S@`",
),
},
# output_to_genfiles is required for header files.
output_to_genfiles = True,
implementation = enum_targets_gen_impl,
)
2 changes: 0 additions & 2 deletions utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@ def _gentbl_rule_impl(ctx):
gentbl_rule = rule(
_gentbl_rule_impl,
doc = "Generates tabular code from a table definition file.",
# Match genrule behavior
output_to_genfiles = True,
attrs = {
"tblgen": attr.label(
doc = "The TableGen executable with which to generate `out`.",
Expand Down