Enable building 16 bit floating point builtins in apple platforms if supported by the compiler #84192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported by the compiler.
TNorthover
approved these changes
Mar 8, 2024
|
The use case here was that if someone was using a recent clang to build Julia, it would try to use the new types and blow up. |
|
bump! |
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…supported by the compiler (llvm#84192) Currently we will not build float16/bfloat16 builtins on apple platforms, LLVM will include calls to those builtins and fail to link. I copied the test code we perform for non apple platforms because oddly we branch on it being apple for building builtins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we will not build float16/bfloat16 builtins on apple platforms, LLVM will include calls to those builtins and fail to link.
I copied the test code we perform for non apple platforms because oddly we branch on it being apple for building builtins