Skip to content

Revert "[AMDGPU] Add AMDGPU specific variadic operation MCExprs" #84273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions llvm/docs/AMDGPUUsage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1534,25 +1534,6 @@ The AMDGPU backend supports the following calling conventions:

=============================== ==========================================================

AMDGPU MCExpr
-------------

As part of the AMDGPU MC layer, AMDGPU provides the following target specific
``MCExpr``\s.

.. table:: AMDGPU MCExpr types:
:name: amdgpu-mcexpr-table

=================== ================= ========================================================
MCExpr Operands Return value
=================== ================= ========================================================
``max(arg, ...)`` 1 or more Variadic signed operation that returns the maximum
value of all its arguments.

``or(arg, ...)`` 1 or more Variadic signed operation that returns the bitwise-or
result of all its arguments.

=================== ================= ========================================================

.. _amdgpu-elf-code-object:

Expand Down
55 changes: 0 additions & 55 deletions llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
//===----------------------------------------------------------------------===//

#include "AMDKernelCodeT.h"
#include "MCTargetDesc/AMDGPUMCExpr.h"
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
#include "MCTargetDesc/AMDGPUTargetStreamer.h"
#include "SIDefines.h"
Expand Down Expand Up @@ -1817,7 +1816,6 @@ class AMDGPUAsmParser : public MCTargetAsmParser {

public:
void onBeginOfFile() override;
bool parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) override;

ParseStatus parseCustomOperand(OperandVector &Operands, unsigned MCK);

Expand Down Expand Up @@ -8279,59 +8277,6 @@ void AMDGPUAsmParser::onBeginOfFile() {
getTargetStreamer().EmitDirectiveAMDGCNTarget();
}

/// Parse AMDGPU specific expressions.
///
/// expr ::= or(expr, ...) |
/// max(expr, ...)
///
bool AMDGPUAsmParser::parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) {
using AGVK = AMDGPUVariadicMCExpr::VariadicKind;

if (isToken(AsmToken::Identifier)) {
StringRef TokenId = getTokenStr();
AGVK VK = StringSwitch<AGVK>(TokenId)
.Case("max", AGVK::AGVK_Max)
.Case("or", AGVK::AGVK_Or)
.Default(AGVK::AGVK_None);

if (VK != AGVK::AGVK_None && peekToken().is(AsmToken::LParen)) {
SmallVector<const MCExpr *, 4> Exprs;
uint64_t CommaCount = 0;
lex(); // Eat 'max'/'or'
lex(); // Eat '('
while (true) {
if (trySkipToken(AsmToken::RParen)) {
if (Exprs.empty()) {
Error(getToken().getLoc(),
"empty " + Twine(TokenId) + " expression");
return true;
}
if (CommaCount + 1 != Exprs.size()) {
Error(getToken().getLoc(),
"mismatch of commas in " + Twine(TokenId) + " expression");
return true;
}
Res = AMDGPUVariadicMCExpr::create(VK, Exprs, getContext());
return false;
}
const MCExpr *Expr;
if (getParser().parseExpression(Expr, EndLoc))
return true;
Exprs.push_back(Expr);
bool LastTokenWasComma = trySkipToken(AsmToken::Comma);
if (LastTokenWasComma)
CommaCount++;
if (!LastTokenWasComma && !isToken(AsmToken::RParen)) {
Error(getToken().getLoc(),
"unexpected token in " + Twine(TokenId) + " expression");
return true;
}
}
}
}
return getParser().parsePrimaryExpr(Res, EndLoc, nullptr);
}

ParseStatus AMDGPUAsmParser::parseOModSI(OperandVector &Operands) {
StringRef Name = getTokenStr();
if (Name == "mul") {
Expand Down
94 changes: 0 additions & 94 deletions llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.cpp

This file was deleted.

74 changes: 0 additions & 74 deletions llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.h

This file was deleted.

1 change: 0 additions & 1 deletion llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ add_llvm_component_library(LLVMAMDGPUDesc
AMDGPUInstPrinter.cpp
AMDGPUMCAsmInfo.cpp
AMDGPUMCCodeEmitter.cpp
AMDGPUMCExpr.cpp
AMDGPUMCTargetDesc.cpp
AMDGPUTargetStreamer.cpp
R600InstPrinter.cpp
Expand Down
Loading