-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang] Add CodeGen tests for CWG 5xx issues #84303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| namespace dr519 { // dr519: 2.7 | ||
| void f() { | ||
| int *a = 0; | ||
| void *v = a; | ||
| bool c1 = v == static_cast<void *>(0); | ||
|
|
||
| void *w = 0; | ||
| int *b = static_cast<int*>(w); | ||
| bool c2 = b == static_cast<int *>(0); | ||
| } | ||
| } // namespace dr519 | ||
|
|
||
| // We're checking that `null`s that were initially stored in `a` and `w` | ||
| // are simply copied over all the way to respective comparisons with `null`. | ||
|
|
||
| // CHECK-LABEL: define {{.*}} void @dr519::f()() | ||
| // CHECK: store ptr null, ptr [[A:%.+]], | ||
| // CHECK-NEXT: [[TEMP_A:%.+]] = load ptr, ptr [[A]] | ||
| // CHECK-NEXT: store ptr [[TEMP_A]], ptr [[V:%.+]], | ||
| // CHECK-NEXT: [[TEMP_V:%.+]] = load ptr, ptr [[V]] | ||
| // CHECK-NEXT: {{.+}} = icmp eq ptr [[TEMP_V]], null | ||
|
|
||
| // CHECK: store ptr null, ptr [[W:%.+]], | ||
| // CHECK-NEXT: [[TEMP_W:%.+]] = load ptr, ptr [[W]] | ||
| // CHECK-NEXT: store ptr [[TEMP_W]], ptr [[B:%.+]], | ||
| // CHECK-NEXT: [[TEMP_B:%.+]] = load ptr, ptr [[B]] | ||
| // CHECK-NEXT: {{.+}} = icmp eq ptr [[TEMP_B]], null | ||
| // CHECK-LABEL: } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| namespace dr571 { // dr571: 2.7 | ||
| typedef int &ir; | ||
| int n; | ||
| const ir r = n; | ||
| // expected-warning@-1 {{'const' qualifier on reference type 'ir' (aka 'int &') has no effect}} | ||
| ir r2 = n; | ||
| } | ||
|
|
||
| // Entities have external linkage by default. | ||
|
|
||
| // CHECK: @dr571::r = constant ptr @dr571::n | ||
| // CHECK: @dr571::r2 = constant ptr @dr571::n | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are showing up as 'dso_local' here: https://godbolt.org/z/Mcxz9c7PG
It isn't clear to me why, or really what it means semantically (https://llvm.org/docs/LangRef.html#runtime-preemption-specifiers).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://llvm.org/docs/LangRef.html#linkage-types, entities with no linkage specified are external, and that's what matters in this test, as it has direct correspondence to linkage the Standard speaks of.
I'm not sure what do we need to pass to
-cc1to makedso_localappear as it does on CE, but my understanding that if you load your dynamic library multiple times into the same process, each would maintain its own set ofdso_localentities. So it's like internal linkage, but on dynamic linker level. Which doesn't seem interesting for this test.