[openmp][wasm] Fix microtask type mismatch #84355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OpenMP is compiled for WebAssembly (see llvm#71297), it invokes a microtask via a `switch` statement that dispatches to the `void *` microtask pointer with spelled-out arguments (not varargs). As llvm#83329 points out, however, this can result in a type mismatch when the indirect call is executed by WebAssembly; WebAssembly expects the called pointer to have the precise type of the call site. This change fixes the issue by bringing back the approach in [D142593] of type-casting all the `switch` arms to the precise type. This fixes llvm#83329. [D142593]: https://reviews.llvm.org/D142593
|
@jpeyton52, can you take a look at this? |
abrown
added a commit
to abrown/wasm-openmp-examples
that referenced
this pull request
Mar 15, 2024
As [#83329] points out, users of the OpenMP WebAssembly port in upstream LLVM could run into issues with indirect call type mismatches. [#84355] fixes that problem, so this commit updates the example to use that fix. It first changes the `llvm-project` submodule to point upstream, since all of the work is now merged there, and also changes that submodule to point directly at the commit for [#84355]. [#83329]: llvm/llvm-project#83329 [#84355]: llvm/llvm-project#84355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OpenMP is compiled for WebAssembly (see #71297), it invokes a microtask via a
switchstatement that dispatches to thevoid *microtask pointer with spelled-out arguments (not varargs). As #83329 points out, however, this can result in a type mismatch when the indirect call is executed by WebAssembly; WebAssembly expects the called pointer to have the precise type of the call site. This change fixes the issue by bringing back the approach in D142593 of type-casting all theswitcharms to the precise type. This fixes #83329.