Skip to content

[libc] finish documenting c23 additions #84383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

nickdesaulniers
Copy link
Member

@nickdesaulniers nickdesaulniers commented Mar 7, 2024

  • [libc] finish documenting c23 additions
  • sort according to appearance in Annex B and section 7

@llvmbot llvmbot added the libc label Mar 7, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 7, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes
  • [libc] finish document c23 additions
  • sort according to appearance in Annex B and section 7

Full diff: https://github.com/llvm/llvm-project/pull/84383.diff

1 Files Affected:

  • (modified) libc/docs/c23.rst (+79-33)
diff --git a/libc/docs/c23.rst b/libc/docs/c23.rst
index ec9d40947cc567..17458aed72147b 100644
--- a/libc/docs/c23.rst
+++ b/libc/docs/c23.rst
@@ -15,36 +15,15 @@ Implementation Status
 
 (It's helpful to review 'Annex B (Informative) Library Summary' for these.)
 
-New headers:
-
-* stdbit.h
-* stdckdint.h (|check|, macros are only defined with `__GNUC__` builtins)
 
 Additions:
 
-* uchar.h
-
-  * mbrtoc8
-  * c8rtomb
-  * char*_t
-
-* string.h
-
-  * memset_explicit
-  * memccpy
-  * strdup
-  * strndup
-
-* time.h
-
-  * gmtime_r
-  * localtime_r
-  * timegm
-  * timespec_getres
-  * strftime conversion specifiers
+* fenv.h
 
-    * 0b
-    * 0B
+  * fesetexcept
+  * fetestexceptflag
+  * fegetmode
+  * fesetmode
 * math.h
 
   * acospi*
@@ -96,20 +75,87 @@ Additions:
   * dfmal
   * fsqrt*
   * dsqrtl
-* fenv.h
-
-  * fesetexcept
-  * fetestexceptflag
-  * fegetmode
-  * fesetmode
+* stdbit.h (New header)
+* stdckdint.h (New header) |check|
 * stddef.h
 
   * unreachable
 * stdlib.h
 
+  * strfromd
+  * strfromf
+  * strfroml
   * free_sized
   * free_aligned_sized
   * memalignment
+* string.h
+
+  * memset_explicit
+  * memccpy
+  * strdup
+  * strndup
 * tgmath.h
 
-  * <TODO>
+  * acospi
+  * asinpi
+  * atan2pi
+  * atanpi
+  * compoundn
+  * cospi
+  * erf
+  * exp10m1
+  * exp10
+  * exp2m1
+  * fmaximum
+  * fmaximum_mag
+  * fmaximum_num
+  * fmaximum_mag_num
+  * fminimum
+  * fminimum_mag
+  * fminimum_num
+  * fminimum_mag_num
+  * fromfpx
+  * fromfp
+  * llogb
+  * log10p1
+  * log2p1
+  * logp1
+  * nextdown
+  * nextup
+  * pown
+  * powr
+  * rootn
+  * roundeven
+  * rsqrt
+  * scalbn
+  * sinpi
+  * tanpi
+  * ufromfpx
+  * ufromfp
+  * fadd
+  * dadd
+  * fsub
+  * dsub
+  * fmul
+  * dmul
+  * fdiv
+  * ddiv
+  * ffma
+  * dfma
+  * fsqrt
+  * dsqrt
+* time.h
+
+  * gmtime_r
+  * localtime_r
+  * timegm
+  * timespec_getres
+  * strftime conversion specifiers
+
+    * 0b
+    * 0B
+* uchar.h
+
+  * mbrtoc8
+  * c8rtomb
+  * char*_t

@nickdesaulniers nickdesaulniers changed the title [libc] finish document c23 additions [libc] finish documenting c23 additions Mar 7, 2024
@nickdesaulniers
Copy link
Member Author

Note to reviewers, it might be helpful to review this PR commit by commit. The final commit is just a sort.

@SchrodingerZhu
Copy link
Contributor

Could help mark memset_explicit as checked?

@nickdesaulniers
Copy link
Member Author

Could help mark memset_explicit as checked?

Good idea!
453a473

Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickdesaulniers nickdesaulniers merged commit 3712edb into llvm:main Mar 7, 2024
@nickdesaulniers nickdesaulniers deleted the docs branch March 7, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants