-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Update the "Current Status" section of the website to be current. #84507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-libcxx Author: Eric (EricWF) ChangesThe section discusses the reasons for the libraries inception more than The initial section remains below. Full diff: https://github.com/llvm/llvm-project/pull/84507.diff 1 Files Affected:
diff --git a/libcxx/docs/index.rst b/libcxx/docs/index.rst
index aa1bd4b83b265b..5317351e0722a9 100644
--- a/libcxx/docs/index.rst
+++ b/libcxx/docs/index.rst
@@ -65,7 +65,17 @@ Getting Started with libc++
Current Status
==============
+libc++ has become the default C++ Standard Library implementation for many major platforms, including Apple's macOS, iOS,
+watchOS, and tvOS, as well as Google's Android operating system. As a result, libc++ has an estimated user base of
+over 1 billion daily active users, making it one of the most widely-deployed C++ Standard Libraries in the world.
+Since its inception, libc++ has focused on delivering high performance, standards-conformant, and portability.
+It has been extensively tested and optimized, making it one of the most efficient implementations of the C++ Standard
+Library available. libc++ continues to evolve and improve, with more updates and more contributors every day, allowing
+it to maintain its position as a top-tier choice for C++ developers across a wide range of platforms.
+
+History
+-------
After its initial introduction, many people have asked "why start a new
library instead of contributing to an existing library?" (like Apache's
libstdcxx, GNU's libstdc++, STLport, etc). There are many contributing
|
The section discusses the reasons for the libraries inception more than a decade ago. Now it discusses the progess libc++ has made, and the many impressive acomplishments our contributors have brought it. The initial section remains below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I feel the wording is quite a bit "marking speech". Next to that I think it would be nice to add a bit more status information. For example,
"libc++ fully implements C++03, C++11, and C++14. C++17 is almost complete, C++20, C++23, and C++26 are making good progress."
Maybe also mention something regarding the CI, the number of platforms and configurations tested. I don't mind a bit fuzzy wording to avoid bit rot.
libcxx/docs/index.rst
Outdated
libc++ has become the default C++ Standard Library implementation for many major platforms, including Apple's macOS, iOS, | ||
watchOS, and tvOS, as well as Google's Android operating system. As a result, libc++ has an estimated user base of | ||
over 1 billion daily active users, making it one of the most widely-deployed C++ Standard Libraries in the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mention FreeBSD too, it has a lower user base but still would be nice to mention them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
How's the new draft? I can't help but be a bit proud and flashy, but the added description was a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes a lot of sense to have a new "Current Status" since the old one was super outdated. I think we could tone it down a bit though, it feels a bit flashy. I would especially tone down any claim that is not substantiated clearly. For example, the claim of being amongst the most efficient implementations -- I personally don't fully know where we stand compared to other implementations. I would expect we're doing pretty good especially with @philnik777 's recent work but I don't know for a fact where we stand.
libcxx/docs/index.rst
Outdated
|
||
Since its inception, libc++ has focused on delivering high performance, standards-conformant, and portability. It has | ||
been extensively tested and optimized, making it one of the most efficient implementations of the C++ Standard Library | ||
available. libc++ fully implements C++11, C++14, and C++17, with C++20, C++23, and C++26 features being actively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We technically don't implement all of C++17 yet.
I have not objection against proud and flashy, I just felt we lacked a bit substance. I leave the approval to @ldionne. |
Co-authored-by: Louis Dionne <[email protected]>
Co-authored-by: Louis Dionne <[email protected]>
Co-authored-by: Louis Dionne <[email protected]>
As requested.
@ldionne I believe I addressed your concerns. I'm happy to address further concerns post-commit. |
The section discusses the reasons for the libraries inception more than
a decade ago. Now it discusses the progess libc++ has made, and the many
impressive acomplishments our contributors have brought it.
The initial section remains below.