[MLIR] Add missing MLIRFuncDialect dep to MLIRMemRefToLLVM #84546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a failure when doing a clean build of lib/libMLIRMemRefToLLVM.a only.
|
@llvm/pr-subscribers-mlir Author: Thomas Preud'homme (RoboTux) ChangesThis fixes a failure when doing a clean build of Full diff: https://github.com/llvm/llvm-project/pull/84546.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt b/mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt
index 1400618c93e850..f0d95f5ada290e 100644
--- a/mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt
+++ b/mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt
@@ -14,6 +14,7 @@ add_mlir_conversion_library(MLIRMemRefToLLVM
LINK_LIBS PUBLIC
MLIRAnalysis
MLIRDataLayoutInterfaces
+ MLIRFuncDialect
MLIRLLVMCommonConversion
MLIRMemRefDialect
MLIRMemRefUtils
|
|
Ping? |
joker-eph
approved these changes
Mar 20, 2024
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
This fixes the following failure when doing a clean build (in particular no .ninja* lying around) of lib/libMLIRMemRefToLLVM.a only: ``` In file included from mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp:18: mlir/include/mlir/Dialect/Func/IR/FuncOps.h:29:10: fatal error: mlir/Dialect/Func/IR/FuncOps.h.inc: No such file or directory ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following failure when doing a clean build (in particular
no .ninja* lying around) of lib/libMLIRMemRefToLLVM.a only: