[MLIR] Add missing MLIRFuncDialect dep to MLIRAffineAnalysis

[RoboTux]

This fixes the following failure when doing a clean build (in particular
no .ninja* lying around) of lib/libMLIRAffineAnalysis.a only:

In file included from mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp:20:
mlir/include/mlir/Dialect/Func/IR/FuncOps.h:29:10: fatal error: mlir/Dialect/Func/IR/FuncOps.h.inc: No such file or directory

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Thomas Preud'homme (RoboTux)

Changes

Note: lib/libMLIRAffineAnalysis.a does build successfully in Ninja
without this patch. The missing dependency was discovered when
converting the CMake build system to bob which put output for each
target in their own build directory. A missing dependency will thus fail
because even though the target dep might be built indirectly, the
path to the dep will not be added to the include path and files are not
found when building the target.

---

Full diff: https://github.com/llvm/llvm-project/pull/84555.diff

1 Files Affected:

• (modified) mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt (+1)

diff --git a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
index 61e49b0da8b2d0..3210d88c260035 100644
--- a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
+++ b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
@@ -14,6 +14,7 @@ add_mlir_dialect_library(MLIRAffineAnalysis
   MLIRCallInterfaces
   MLIRControlFlowInterfaces
   MLIRDialectUtils
+  MLIRFuncDialect
   MLIRInferTypeOpInterface
   MLIRSideEffectInterfaces
   MLIRPresburger

[llvmbot]

@llvm/pr-subscribers-mlir-affine

Author: Thomas Preud'homme (RoboTux)

Changes

Note: lib/libMLIRAffineAnalysis.a does build successfully in Ninja
without this patch. The missing dependency was discovered when
converting the CMake build system to bob which put output for each
target in their own build directory. A missing dependency will thus fail
because even though the target dep might be built indirectly, the
path to the dep will not be added to the include path and files are not
found when building the target.

---

Full diff: https://github.com/llvm/llvm-project/pull/84555.diff

1 Files Affected:

• (modified) mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt (+1)

diff --git a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
index 61e49b0da8b2d0..3210d88c260035 100644
--- a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
+++ b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
@@ -14,6 +14,7 @@ add_mlir_dialect_library(MLIRAffineAnalysis
   MLIRCallInterfaces
   MLIRControlFlowInterfaces
   MLIRDialectUtils
+  MLIRFuncDialect
   MLIRInferTypeOpInterface
   MLIRSideEffectInterfaces
   MLIRPresburger

[joker-eph]

Can you add the failure to the description? (for this PR and all the other similar fixes)

I don't reproduce at head with ninja clean && ninja lib/libMLIRAffineAnalysis.a right now.

[RoboTux]

Ping?

[matthias-springer]

Can you try to remove the FuncOps.h include from AffineAnalysis.cpp instead? I don't see any uses of func dialect ops in that file.

[RoboTux]

It worked, I've created a new PR since this is a different patch: #85912.

Closing this one.