Skip to content

[BOLT][DWWARF] Fix foreign TU index with local TUs #84594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ayermolo
Copy link
Contributor

@ayermolo ayermolo commented Mar 9, 2024

The foreign TU list immediately follows the local TU list and they both use the same index, so that if there are N local TU entries, the index for the first foreign TU is N.

Changed so that the size of local TU is accounted for when setting foreign TU index.

The foreign TU list immediately follows the local TU list and they both use the
same index, so that if there are N local TU entries, the index for the first
foreign TU is N.

Changed so that the size of local TU is accounted for when setting foreign TU
index.
@ayermolo ayermolo added the BOLT label Mar 9, 2024
@ayermolo ayermolo changed the title [BOLT][DWWARF][NFC] Fix foreign TU index with local TUs [BOLT][DWWARF] Fix foreign TU index with local TUs Mar 11, 2024
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayermolo ayermolo merged commit 6d4aa9d into llvm:main Mar 11, 2024
@ayermolo ayermolo deleted the TUIndexFix branch March 11, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants