[LLDB][doc] Updates build instructions. #84630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently building libc++ requires building libunwind too. This updates the LLDB instructions. I noticed this recently and it was separately filed as llvm#84053
|
@llvm/pr-subscribers-lldb Author: Mark de Wever (mordante) ChangesRecently building libc++ requires building libunwind too. This updates the LLDB instructions. I noticed this recently and it was separately filed as #84053 Full diff: https://github.com/llvm/llvm-project/pull/84630.diff 1 Files Affected:
diff --git a/lldb/docs/resources/build.rst b/lldb/docs/resources/build.rst
index 5f4d35ced6236c..54f7d1cc93c4b0 100644
--- a/lldb/docs/resources/build.rst
+++ b/lldb/docs/resources/build.rst
@@ -331,7 +331,7 @@ macOS
^^^^^
On macOS the LLDB test suite requires libc++. Either add
-``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with
+``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind"`` or disable the test suite with
``LLDB_INCLUDE_TESTS=OFF``. Further useful options:
* ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework.
@@ -370,7 +370,7 @@ LLVM <https://llvm.org/docs/BuildingADistribution.html>`_):
$ cmake -B /path/to/lldb-build -G Ninja \
-C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
-DLLVM_ENABLE_PROJECTS="clang;lldb" \
- -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
+ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \
llvm-project/llvm
$ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution
@@ -386,7 +386,7 @@ Build LLDB standalone for development with Xcode:
$ cmake -B /path/to/llvm-build -G Ninja \
-C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \
-DLLVM_ENABLE_PROJECTS="clang" \
- -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
+ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \
llvm-project/llvm
$ ninja -C /path/to/llvm-build
|
jasonmolenda
approved these changes
Mar 9, 2024
clayborg
approved these changes
Mar 9, 2024
Is this a known issue and is somebody already working on fixing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently building libc++ requires building libunwind too. This updates the LLDB instructions.
I noticed this recently and it was separately filed as #84053