Skip to content

[libc++][CI] Installs tzdata package in Docker. #84643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mordante
Copy link
Member

@mordante mordante commented Mar 9, 2024

This allows testing the time zone information in the CI. This is needed to let #82108 pass the CI.

This allows testing the time zone information in the CI. This is needed
to let llvm#82108 pass the CI.
@mordante mordante requested a review from a team as a code owner March 9, 2024 17:38
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 9, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

This allows testing the time zone information in the CI. This is needed to let #82108 pass the CI.


Full diff: https://github.com/llvm/llvm-project/pull/84643.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/Dockerfile (+6)
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 225de937cc869a..178cba41593388 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -65,6 +65,12 @@ RUN <<EOF
   echo "ALL ALL = (ALL) NOPASSWD: ALL" | tee /etc/sudoers || true
 EOF
 
+# Installing tzdata before other packages avoids the time zone prompts.
+# These prompts seem to ignore DEBIAN_FRONTEND=noninteractive.
+RUN sudo apt-get update \
+    && sudo apt-get install -y \
+        tzdata
+
 RUN sudo apt-get update \
     && sudo apt-get install -y \
         python3 \

@mordante mordante merged commit af21659 into llvm:main Mar 12, 2024
@mordante mordante deleted the review/docker_installs_tzdata branch March 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants