Skip to content

[libc++] Fixes run-buildbot-container. #84644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

mordante
Copy link
Member

@mordante mordante commented Mar 9, 2024

Pulls the proper docker image instead of a non-existing image.

Pulls the proper docker image instead of a non-existing image.
@mordante mordante requested a review from a team as a code owner March 9, 2024 17:42
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 9, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

Pulls the proper docker image instead of a non-existing image.


Full diff: https://github.com/llvm/llvm-project/pull/84644.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/run-buildbot-container (+2-2)
diff --git a/libcxx/utils/ci/run-buildbot-container b/libcxx/utils/ci/run-buildbot-container
index 7c00b88097f17b..b818883349e1cd 100755
--- a/libcxx/utils/ci/run-buildbot-container
+++ b/libcxx/utils/ci/run-buildbot-container
@@ -26,6 +26,6 @@ if [[ ! -d "${MONOREPO_ROOT}/libcxx/utils/ci" ]]; then
     echo "Was unable to find the root of the LLVM monorepo; are you running from within the monorepo?"
     exit 1
 fi
-docker pull ghcr.io/libcxx/libcxx-builder
-docker run -it --volume "${MONOREPO_ROOT}:/llvm" --workdir "/llvm" --cap-add=SYS_PTRACE ghcr.io/libcxx/libcxx-builder \
+docker pull ghcr.io/libcxx/buildkite-builder
+docker run -it --volume "${MONOREPO_ROOT}:/llvm" --workdir "/llvm" --cap-add=SYS_PTRACE ghcr.io/libcxx/buildkite-builder \
     bash -c 'git config --global --add safe.directory /llvm ; exec bash'

@mordante mordante merged commit 2e84176 into llvm:main Mar 15, 2024
@mordante mordante deleted the review/fixes_run-buildbot-container branch March 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants