Get rid of noisy debug log in verifyOpAndAdjustFlags. #84677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This debug log adds noise to a large fraction of *other* debug logs when you run with -debug, because it prints "Verifying operation: blah blah\n" whenever those other debug logs dump an op. You can use -debug-only to get around this, but sometimes -debug really is what's called for!
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Justin Lebar (jlebar) ChangesThis debug log adds noise to a large fraction of other debug logs when you You can use -debug-only to get around this, but sometimes -debug really is Full diff: https://github.com/llvm/llvm-project/pull/84677.diff 1 Files Affected:
diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 8d75349f8eed45..456cf6a2c27783 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -1895,9 +1895,6 @@ static OpPrintingFlags verifyOpAndAdjustFlags(Operation *op,
printerFlags.shouldAssumeVerified())
return printerFlags;
- LLVM_DEBUG(llvm::dbgs() << DEBUG_TYPE << ": Verifying operation: "
- << op->getName() << "\n");
-
// Ignore errors emitted by the verifier. We check the thread id to avoid
// consuming other threads' errors.
auto parentThreadId = llvm::get_threadid();
|
|
@joker-eph friendly ping |
joker-eph
approved these changes
Mar 12, 2024
|
No worries, and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debug log adds noise to a large fraction of other debug logs when you
run with -debug, because it prints "Verifying operation: blah blah\n" whenever
those other debug logs dump an op.
You can use -debug-only to get around this, but sometimes -debug really is
what's called for!