Skip to content

[libc] fix another build failure from using limits.h #84827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

nickdesaulniers
Copy link
Member

My GCC build is failing with issues similar why we added our own. Looks like
we missed one spot. See also:

commit 72ce629 ("[libc] Add C23 limits.h header. (#78887)")

My GCC build is failing with issues similar why we added our own.  Looks like
we missed one spot. See also:

commit 72ce629 ("[libc] Add C23 limits.h header. (llvm#78887)")
@nickdesaulniers nickdesaulniers requested a review from lntue March 11, 2024 20:36
@llvmbot llvmbot added the libc label Mar 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 11, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

My GCC build is failing with issues similar why we added our own. Looks like
we missed one spot. See also:

commit 72ce629 ("[libc] Add C23 limits.h header. (#78887)")


Full diff: https://github.com/llvm/llvm-project/pull/84827.diff

1 Files Affected:

  • (modified) libc/test/src/__support/integer_to_string_test.cpp (+1-2)
diff --git a/libc/test/src/__support/integer_to_string_test.cpp b/libc/test/src/__support/integer_to_string_test.cpp
index a2a80c81b9f69f..270fddd828b680 100644
--- a/libc/test/src/__support/integer_to_string_test.cpp
+++ b/libc/test/src/__support/integer_to_string_test.cpp
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "src/__support/CPP/limits.h"
 #include "src/__support/CPP/span.h"
 #include "src/__support/CPP/string_view.h"
 #include "src/__support/UInt.h"
@@ -15,8 +16,6 @@
 
 #include "test/UnitTest/Test.h"
 
-#include "limits.h"
-
 using LIBC_NAMESPACE::IntegerToString;
 using LIBC_NAMESPACE::cpp::span;
 using LIBC_NAMESPACE::cpp::string_view;

@nickdesaulniers nickdesaulniers merged commit bae47d4 into llvm:main Mar 12, 2024
@nickdesaulniers nickdesaulniers deleted the fix_gcc branch March 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants