Skip to content

[clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass #84852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 5, 2024
Merged

[clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass #84852

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c12c683
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Mar 11, 2024
0b41002
[𝘀𝗽𝗿] initial version
vitalybuka Mar 11, 2024
7ca8112
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Mar 12, 2024
ca6db0c
rebase
vitalybuka Mar 12, 2024
d3ae6d5
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Mar 13, 2024
f29de56
rebase
vitalybuka Mar 13, 2024
8ea52d1
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Apr 2, 2024
027dc2f
rebase
vitalybuka Apr 2, 2024
9877386
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Apr 4, 2024
2be0231
rebase
vitalybuka Apr 4, 2024
4021d38
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Apr 5, 2024
be1f5ed
rebase
vitalybuka Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions clang/lib/CodeGen/BackendUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
#include "llvm/Transforms/Scalar/EarlyCSE.h"
#include "llvm/Transforms/Scalar/GVN.h"
#include "llvm/Transforms/Scalar/JumpThreading.h"
#include "llvm/Transforms/Scalar/SimplifyCFG.h"
#include "llvm/Transforms/Utils/Debugify.h"
#include "llvm/Transforms/Utils/EntryExitInstrumenter.h"
#include "llvm/Transforms/Utils/ModuleUtils.h"
Expand Down Expand Up @@ -753,11 +752,6 @@ static void addSanitizers(const Triple &TargetTriple,
// from `buildInlinerPipeline`, which called after profile matching.
PB.registerScalarOptimizerLateEPCallback(
[](FunctionPassManager &FPM, OptimizationLevel Level) {
// RemoveTrapsPass expects trap blocks preceded by conditional
// branches, which usually is not the case without SimplifyCFG.
// TODO: Remove `SimplifyCFGPass` after switching to dedicated
// intrinsic.
FPM.addPass(SimplifyCFGPass());
FPM.addPass(RemoveTrapsPass());
});
}
Expand Down