Skip to content

Mark test as XFAIL that started failing after 418f0066eb. #85027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dyung
Copy link
Collaborator

@dyung dyung commented Mar 13, 2024

Similar failures were previously seen and XFAILed in https://reviews.llvm.org/D118468.

See the phabricator review for a description of the problem, and the linked discourse thread for what the failing output looks like.

This change should fix the issue on two buildbots that are running older versions of GDB:

Similar failures were previously seen and XFAILed in https://reviews.llvm.org/D118468.
@dyung dyung changed the title Mark test as XFAIL that started failing after 418f006. Mark test as XFAIL that started failing after 418f0066eb. Mar 13, 2024
@OCHyams
Copy link
Contributor

OCHyams commented Mar 13, 2024

I'm not entirely sure why the issue is popping up now after 418f006 (I guess the change to the test_debuginfo.pl script dislodged a silent failure, now that the debugger return value is examined?). Either way, given the failure message and how we've dealt with it in the past, this LGTM.

@OCHyams OCHyams merged commit 5a74477 into llvm:main Mar 13, 2024
@OCHyams
Copy link
Contributor

OCHyams commented Mar 13, 2024

Merging to unblock the bots! Thanks @dyung

@dyung dyung deleted the dyung/main/xfail-test branch March 14, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants