Skip to content

[mlir][IR] Add additional rewriter constructor #85044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthias-springer
Copy link
Member

For convenience, add an additional constructor to RewriterBase and IRRewriter that also sets the insertion point. OpBuilder provides a similar constructor.

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Mar 13, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 13, 2024

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Matthias Springer (matthias-springer)

Changes

For convenience, add an additional constructor to RewriterBase and IRRewriter that also sets the insertion point. OpBuilder provides a similar constructor.


Full diff: https://github.com/llvm/llvm-project/pull/85044.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/PatternMatch.h (+4)
diff --git a/mlir/include/mlir/IR/PatternMatch.h b/mlir/include/mlir/IR/PatternMatch.h
index ef53a0b82866fc..070e6ed702f86a 100644
--- a/mlir/include/mlir/IR/PatternMatch.h
+++ b/mlir/include/mlir/IR/PatternMatch.h
@@ -736,6 +736,8 @@ class RewriterBase : public OpBuilder {
       : OpBuilder(ctx, listener) {}
   explicit RewriterBase(const OpBuilder &otherBuilder)
       : OpBuilder(otherBuilder) {}
+  explicit RewriterBase(Operation *op, OpBuilder::Listener *listener = nullptr)
+      : OpBuilder(op, listener) {}
   virtual ~RewriterBase();
 
 private:
@@ -756,6 +758,8 @@ class IRRewriter : public RewriterBase {
   explicit IRRewriter(MLIRContext *ctx, OpBuilder::Listener *listener = nullptr)
       : RewriterBase(ctx, listener) {}
   explicit IRRewriter(const OpBuilder &builder) : RewriterBase(builder) {}
+  explicit IRRewriter(Operation *op, OpBuilder::Listener *listener = nullptr)
+      : RewriterBase(op, listener) {}
 };
 
 //===----------------------------------------------------------------------===//

@matthias-springer matthias-springer merged commit 437fcc6 into main Mar 14, 2024
@matthias-springer matthias-springer deleted the users/matthias-springer/rewriter_constructor branch March 14, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants