Skip to content

[libc++abi] Disable forced_unwind4 test for musl. #85096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

al45tair
Copy link
Contributor

This test won't pass on musl, but we should still run it for other Linux platforms.

rdar://123436716

This test won't pass on musl, but we should still run it
for other Linux platforms.

rdar://123436716
@al45tair al45tair requested a review from a team as a code owner March 13, 2024 14:59
@llvmbot llvmbot added the libc++abi libc++abi C++ Runtime Library. Not libc++. label Mar 13, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 13, 2024

@llvm/pr-subscribers-libcxxabi

Author: Alastair Houghton (al45tair)

Changes

This test won't pass on musl, but we should still run it for other Linux platforms.

rdar://123436716


Full diff: https://github.com/llvm/llvm-project/pull/85096.diff

1 Files Affected:

  • (modified) libcxxabi/test/forced_unwind4.pass.cpp (+2-2)
diff --git a/libcxxabi/test/forced_unwind4.pass.cpp b/libcxxabi/test/forced_unwind4.pass.cpp
index 2864426ca16dcd..15efca8d931629 100644
--- a/libcxxabi/test/forced_unwind4.pass.cpp
+++ b/libcxxabi/test/forced_unwind4.pass.cpp
@@ -7,10 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// REQUIRES: linux && target={{aarch64-.+}}
+// REQUIRES: linux && target=aarch64-{{.+}}-gnu
 
 // pthread_cancel in case of glibc calls _Unwind_ForcedUnwind from a signal on
-// the child_thread. This test ensures sigretrun is handled correctly (see:
+// the child_thread. This test ensures sigreturn is handled correctly (see:
 // UnwindCursor<A, R>::setInfoForSigReturn).
 
 #include <cstdlib> // defines __BIONIC__

@ldionne ldionne merged commit 7be847e into llvm:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++abi libc++abi C++ Runtime Library. Not libc++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants