[clang] Fix assertion failure when printing atomic apvalues

[tbaederr]

When printing an _Atomic(some struct type), we would later run into an assertion because we do a Ty->castAs<RecordType>(), which doesn't work with an AtomicType.

Not sure how to best write a test for, this, but OTOH, printPretty is currently only used for debugging as far as I know(?).

[llvmbot]

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

Changes

When printing an _Atomic(some struct type), we would later run into an assertion because we do a Ty->castAs<RecordType>(), which doesn't work with an AtomicType.

Not sure how to best write a test for, this, but OTOH, printPretty is currently only used for debugging as far as I know(?).

---

Full diff: https://github.com/llvm/llvm-project/pull/85259.diff

1 Files Affected:

• (modified) clang/lib/AST/APValue.cpp (+3)

diff --git a/clang/lib/AST/APValue.cpp b/clang/lib/AST/APValue.cpp
index 4eae308ef5b34c..d8042321319a67 100644
--- a/clang/lib/AST/APValue.cpp
+++ b/clang/lib/AST/APValue.cpp
@@ -704,6 +704,9 @@ void APValue::printPretty(raw_ostream &Out, const PrintingPolicy &Policy,
     return;
   }
 
+  if (const auto *AT = Ty->getAs<AtomicType>())
+    Ty = AT->getValueType();
+
   switch (getKind()) {
   case APValue::None:
     Out << "<out of lifetime>";

[tbaederr]

Ping

[tbaederr]

Ping

[AaronBallman]

LGTM but this should be testable because getAsString() uses printPretty():

llvm-project/clang/lib/AST/Interp/FunctionPointer.h

Line 53 in e6f63a9

return toAPValue().getAsString(Ctx, Func->getDecl()->getType());

,

llvm-project/clang/lib/AST/ExprConstant.cpp

Line 1674 in e6f63a9

return Printable.getAsString(Ctx, T);

, etc

[tbaederr]

Right, I was just hoping for an existing unittest for APValue.