[libc++][CI] Updates the documentation. #85264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation mentions manually pushing Docker images to the CI. The preferred way is to use the proper GitHub action. This updates the documentation.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesThe documentation mentions manually pushing Docker images to the CI. The preferred way is to use the proper GitHub action. This updates the documentation. Full diff: https://github.com/llvm/llvm-project/pull/85264.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 178cba41593388..2dca0282e44391 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -7,15 +7,13 @@
#===----------------------------------------------------------------------===##
#
# This file defines the buildkite and github actions builder images.
-# You can build & push both images using:
+# You can build both images using:
#
# docker compose build
-# docker compose push
#
-# Or you can select a single image to build & push using:
+# Or you can select a single image to build
#
# docker compose build buildkite-builder
-# docker compose push buildkite-builder
#
# The final images can be found at
#
@@ -23,7 +21,8 @@
# ghcr.io/libcxx/actions-builder
# ghcr.io/libcxx/android-buildkite-builder
#
-# Members of the github.com/libcxx/ organizations have permissions required to push new images.
+# Members of the github.com/libcxx/ organizations can push new images to the CI
+# This is done by GitHub actions in the https://github.com/libcxx/builders repo.
#
# ===----------------------------------------------------------------------===##
# Running the buildkite image
|
hawkinsw
reviewed
Mar 14, 2024
hawkinsw
reviewed
Mar 14, 2024
Co-authored-by: Will Hawkins <[email protected]>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation mentions manually pushing Docker images to the CI. The preferred way is to use the proper GitHub action. This updates the documentation.