[PassBuilder] Expose parametrized passes related functions #85357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Mar 15, 2024
Comment on lines
661
to
662
| assert(false && | ||
| "unable to strip pass name from parametrized pass specification"); |
| } | ||
| if (!Params.empty() && | ||
| (!Params.consume_front("<") || !Params.consume_back(">"))) { | ||
| assert(false && "invalid format for parametrized pass name"); |
Example in AMDGPU, |
Can you add to the commit description? |
paperchalice
force-pushed
the
pb
branch
2 times, most recently
from
9a0c055 to
2200b53
Compare
Some targets have passes with parameters, e.g. ARM, AMDGPU and MIPS. For example, AMDGPU has a pass `AMDGPUAtomicOptimizerPass` which need a `ScanOption`, this commit enables the syntax like `-passes=amdgpu-atomic-optimizer<strategy=dpp>` for backend passes.
arsenm
approved these changes
Mar 15, 2024
aeubanks
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some targets have passes with parameters, e.g. ARM, AMDGPU and MIPS.
For example, AMDGPU has a pass
AMDGPUAtomicOptimizerPasswhich need a
ScanOption, this commit enables the syntaxlike
-passes=amdgpu-atomic-optimizer<strategy=dpp>for backend passes.