Skip to content

[mlir][inliner] Assert that no external nodes passed to the profitability hook. #85489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[mlir][inliner] Assert that no external nodes passed to the profitability hook. #85489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions mlir/lib/Transforms/InlinerPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,7 @@ static bool isProfitableToInline(const Inliner::ResolvedCall &resolvedCall,
Region *callerRegion = resolvedCall.sourceNode->getCallableRegion();
Region *calleeRegion = resolvedCall.targetNode->getCallableRegion();

// We should not get external nodes here, but just return true
// for now to preserve the original behavior of the inliner pass.
if (!callerRegion || !calleeRegion)
return true;
assert(calleeRegion && callerRegion && "unexpected external node");

auto countOps = [](Region *region) {
unsigned count = 0;
Expand Down