Skip to content

[Driver] -fsanitize=undefined: don't expand to signed-integer-overflow if -fwrapv #85501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Driver] -fsanitize=undefined: don't expand to signed-integer-overflow if -fwrapv #85501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clang/lib/Driver/SanitizerArgs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,14 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC,
Add &= ~NotAllowedWithExecuteOnly;
if (CfiCrossDso)
Add &= ~SanitizerKind::CFIMFCall;
// -fsanitize=undefined does not expand to signed-integer-overflow in
// -fwrapv (implied by -fno-strict-overflow) mode.
if (Add & SanitizerKind::UndefinedGroup) {
bool S = Args.hasFlagNoClaim(options::OPT_fno_strict_overflow,
options::OPT_fstrict_overflow, false);
if (Args.hasFlagNoClaim(options::OPT_fwrapv, options::OPT_fno_wrapv, S))
Add &= ~SanitizerKind::SignedIntegerOverflow;
}
Add &= Supported;

if (Add & SanitizerKind::Fuzzer)
Expand Down
28 changes: 28 additions & 0 deletions clang/test/Driver/fsanitize-signed-integer-overflow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/// When -fwrapv (implied by -fno-strict-overflow) is enabled,
/// -fsanitize=undefined does not expand to signed-integer-overflow.
/// -fsanitize=signed-integer-overflow is unaffected by -fwrapv.

// RUN: %clang -### --target=x86_64-linux -fwrapv -fsanitize=signed-integer-overflow %s 2>&1 | FileCheck %s
// CHECK: -fsanitize=signed-integer-overflow
// CHECK: -fsanitize-recover=signed-integer-overflow

// RUN: %clang -### --target=x86_64-linux -fno-strict-overflow -fsanitize=undefined %s 2>&1 | FileCheck %s --check-prefix=EXCLUDE
// RUN: %clang -### --target=x86_64-linux -fstrict-overflow -fwrapv -fsanitize=undefined %s 2>&1 | FileCheck %s --check-prefix=EXCLUDE
// EXCLUDE: -fsanitize=alignment,array-bounds,
// EXCLUDE-NOT: signed-integer-overflow,
// EXCLUDE: -fsanitize-recover=alignment,array-bounds,
// EXCLUDE-SAME: signed-integer-overflow

// RUN: %clang -### --target=x86_64-linux -fwrapv -fsanitize=undefined -fsanitize=signed-integer-overflow %s 2>&1 | FileCheck %s --check-prefix=INCLUDE
// RUN: %clang -### --target=x86_64-linux -fno-strict-overflow -fno-sanitize=signed-integer-overflow -fsanitize=undefined -fsanitize=signed-integer-overflow %s 2>&1 | FileCheck %s --check-prefix=INCLUDE
// INCLUDE: -fsanitize=alignment,array-bounds,
// INCLUDE-SAME: signed-integer-overflow
// INCLUDE: -fsanitize-recover=alignment,array-bounds,
// INCLUDE-SAME: signed-integer-overflow

/// -fsanitize-trap=undefined expands to signed-integer-overflow regardless of -fwrapv.
// RUN: %clang -### --target=x86_64-linux -fwrapv -fsanitize=undefined -fsanitize=signed-integer-overflow -fsanitize-trap=undefined %s 2>&1 | FileCheck %s --check-prefix=INCLUDE-TRAP
// INCLUDE-TRAP: -fsanitize=alignment,array-bounds,
// INCLUDE-TRAP-SAME: signed-integer-overflow
// INCLUDE-TRAP: -fsanitize-trap=alignment,array-bounds,
// INCLUDE-TRAP-SAME: signed-integer-overflow