[mlir][OpInterfacesGen][NFC] Add newline after traits declaration #85633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly improve the readability of the tablegen-generated code. Co-authored-by: Orest Chura <[email protected]>
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Andrei Golubev (andrey-golubev) ChangesSlightly improve the readability of the tablegen-generated code. Full diff: https://github.com/llvm/llvm-project/pull/85633.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp b/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp
index 9672a02cc08f68..2a7406f42f34b5 100644
--- a/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpInterfacesGen.cpp
@@ -533,7 +533,7 @@ void InterfaceGenerator::emitInterfaceDecl(const Interface &interface) {
<< "struct " << interfaceTraitsName << " {\n";
emitConceptDecl(interface);
emitModelDecl(interface);
- os << "};";
+ os << "};\n";
// Emit the derived trait for the interface.
os << "template <typename " << valueTemplate << ">\n";
|
zero9178
approved these changes
Mar 18, 2024
|
@zero9178 could you merge as well? (I lack write access) |
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
…vm#85633) Slightly improve the readability of the tablegen-generated code. Co-authored-by: Orest Chura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improve the readability of the tablegen-generated code.