[libclc] Convert tabs to spaces in CMake #85634
Conversation
Having a mix of tabs and spaces makes the diff of any changes to the build system noisier than necessary. This commit unifies them to two spaces. This includes some minor cosmetic changes such as with joining things on one line where appropriate. There are other files in libclc which have tabs but those haven't been touched at this time. Those could come at another time if desired, though they might be more contentious as the project isn't clang-formatted at all and so that might invite larger discussions around formatting.
|
@tstellar are you the code owner for |
|
FWIW I don't think the build bots are actually building Locally, at least, it's not sufficient to specify I had a patch locally to switch Another problem is that all |
I'm not aware of any bots building libclc. It would be nice if you could build libclc more easily, it does not fit in with the rest of the projects right now. Any improvements you want to make in this area would be welcome. |
Ah, yeah that's possible. I mentioned it because https://github.com/llvm/llvm-project/blob/main/.github/workflows/libclc-tests.yml and https://buildkite.com/llvm-project/github-pull-requests/builds/48183#018e5157-23d0-4c70-b8bc-54bbdceabb6c look like they're ostensibly trying to build it, but aren't. I'll see what I can do to improve the situation. We're mostly working with libclc downstream in DPC++ and it's been changed quite significantly, so it's a bit delicate to get the balance right. |
This mirrors a change made to upstream LLVM in llvm/llvm-project#85634, but since we've made downstream changes we have to do the work in two places. Some of this will cause merge conflicts when pulling down upstream LLVM but I don't know how we can avoid that. Some of the other files changed in the upstream PR have been left alone here since we'll soon pull those in anyway.
This mirrors a change made to upstream LLVM in llvm/llvm-project#85634, but since we've made downstream changes we have to do the work in two places. Some of this will cause merge conflicts when pulling down upstream LLVM but I don't know how we can avoid that. Some of the other files changed in the upstream PR have been left alone here since we'll soon pull those in anyway.
Having a mix of tabs and spaces makes the diff of any changes to the build system noisier than necessary. This commit unifies them to two spaces. This includes some minor cosmetic changes such as with joining things on one line where appropriate. There are other files in libclc which have tabs but those haven't been touched at this time. Those could come at another time if desired, though they might be more contentious as the project isn't clang-formatted at all and so that might invite larger discussions around formatting.
Having a mix of tabs and spaces makes the diff of any changes to the build system noisier than necessary. This commit unifies them to two spaces.
This includes some minor cosmetic changes such as with joining things on one line where appropriate.
There are other files in libclc which have tabs but those haven't been touched at this time. Those could come at another time if desired, though they might be more contentious as the project isn't clang-formatted at all and so that might invite larger discussions around formatting.