[BOLT] Update DIEStreamer #85818
Merged
[BOLT] Update DIEStreamer #85818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 43a2ec4 Author: Jonas Devlieghere <[email protected]> Date: Tue Mar 19 08:30:47 2024 -0700 removed parameter Translator from the constructor of DwarfStreamer. This patch fixes the build by updating the constructor of DIEStreamer accordingly.
kazutakahirata
requested review from
aaupov,
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
maksfb
approved these changes
Mar 19, 2024
|
Thanks for fixing the BOLT issue. In the meantime, my PR got reverted, so I'm guessing this isn't building right now? I'm building locally to see if this fixes the issue in which case I can reland my commit. |
kazutakahirata
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit e4f9175. commit 3176c15 Author: Andres Villegas <[email protected]> Date: Tue Mar 19 10:58:31 2024 -0700 reverted 43a2ec4.
Thank you for fixing this with 4128340. |
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
commit 43a2ec4 Author: Jonas Devlieghere <[email protected]> Date: Tue Mar 19 08:30:47 2024 -0700 removed parameter Translator from the constructor of DwarfStreamer. This patch fixes the build by updating the constructor of DIEStreamer accordingly.
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
This reverts commit e4f9175. commit 3176c15 Author: Andres Villegas <[email protected]> Date: Tue Mar 19 10:58:31 2024 -0700 reverted 43a2ec4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 43a2ec4
Author: Jonas Devlieghere [email protected]
Date: Tue Mar 19 08:30:47 2024 -0700
removed parameter Translator from the constructor of DwarfStreamer.
This patch fixes the build by updating the constructor of DIEStreamer
accordingly.