[lldb] Invert relationship between Process and AddressableBits #85858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddressableBits is in the Utility module of LLDB. It currently directly refers to Process, which is from the Target LLDB module. This is a layering violation which concretely means that it is impossible to link anything that uses Utility without it also using Target as well. This is generally not an issue for LLDB (since everything is built together) but it may make it difficult to write unit tests for AddressableBits later on.
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesAddressableBits is in the Utility module of LLDB. It currently directly refers to Process, which is from the Target LLDB module. This is a layering violation which concretely means that it is impossible to link anything that uses Utility without it also using Target as well. This is generally not an issue for LLDB (since everything is built together) but it may make it difficult to write unit tests for AddressableBits later on. Full diff: https://github.com/llvm/llvm-project/pull/85858.diff 6 Files Affected:
diff --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h
index e260e1b4b797bc..2f3a3c22422efe 100644
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -43,6 +43,7 @@
#include "lldb/Target/ThreadList.h"
#include "lldb/Target/ThreadPlanStack.h"
#include "lldb/Target/Trace.h"
+#include "lldb/Utility/AddressableBits.h"
#include "lldb/Utility/ArchSpec.h"
#include "lldb/Utility/Broadcaster.h"
#include "lldb/Utility/Event.h"
@@ -3219,6 +3220,8 @@ void PruneThreadPlans();
void LoadOperatingSystemPlugin(bool flush);
+ void SetAddressableBitMasks(AddressableBits bit_masks);
+
private:
Status DestroyImpl(bool force_kill);
diff --git a/lldb/include/lldb/Utility/AddressableBits.h b/lldb/include/lldb/Utility/AddressableBits.h
index 75752fcf840a44..0d27c3561ec272 100644
--- a/lldb/include/lldb/Utility/AddressableBits.h
+++ b/lldb/include/lldb/Utility/AddressableBits.h
@@ -32,11 +32,13 @@ class AddressableBits {
void SetLowmemAddressableBits(uint32_t lowmem_addressing_bits);
+ uint32_t GetLowmemAddressableBits() const;
+
void SetHighmemAddressableBits(uint32_t highmem_addressing_bits);
- static lldb::addr_t AddressableBitToMask(uint32_t addressable_bits);
+ uint32_t GetHighmemAddressableBits() const;
- void SetProcessMasks(lldb_private::Process &process);
+ static lldb::addr_t AddressableBitToMask(uint32_t addressable_bits);
private:
uint32_t m_low_memory_addr_bits;
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 5b9a9d71802f86..871683a605686f 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -900,7 +900,7 @@ void ProcessGDBRemote::DidLaunchOrAttach(ArchSpec &process_arch) {
}
AddressableBits addressable_bits = m_gdb_comm.GetAddressableBits();
- addressable_bits.SetProcessMasks(*this);
+ SetAddressableBitMasks(addressable_bits);
if (process_arch.IsValid()) {
const ArchSpec &target_arch = GetTarget().GetArchitecture();
@@ -2337,7 +2337,7 @@ StateType ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
}
}
- addressable_bits.SetProcessMasks(*this);
+ SetAddressableBitMasks(addressable_bits);
ThreadSP thread_sp = SetThreadStopInfo(
tid, expedited_register_map, signo, thread_name, reason, description,
diff --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
index 7b9938d4f02020..1da7696c9a352a 100644
--- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -574,7 +574,7 @@ Status ProcessMachCore::DoLoadCore() {
CleanupMemoryRegionPermissions();
AddressableBits addressable_bits = core_objfile->GetAddressableBits();
- addressable_bits.SetProcessMasks(*this);
+ SetAddressableBitMasks(addressable_bits);
return error;
}
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 6d58873b54a3ad..f02ec37cb0f08f 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -63,6 +63,7 @@
#include "lldb/Target/ThreadPlanCallFunction.h"
#include "lldb/Target/ThreadPlanStack.h"
#include "lldb/Target/UnixSignals.h"
+#include "lldb/Utility/AddressableBits.h"
#include "lldb/Utility/Event.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
@@ -6453,3 +6454,25 @@ Status Process::CalculateCoreFileSaveRanges(lldb::SaveCoreStyle core_style,
return Status(); // Success!
}
+
+void Process::SetAddressableBitMasks(AddressableBits bit_masks) {
+ uint32_t low_memory_addr_bits = bit_masks.GetLowmemAddressableBits();
+ uint32_t high_memory_addr_bits = bit_masks.GetHighmemAddressableBits();
+
+ if (low_memory_addr_bits == 0 && high_memory_addr_bits == 0)
+ return;
+
+ if (low_memory_addr_bits != 0) {
+ addr_t low_addr_mask =
+ AddressableBits::AddressableBitToMask(low_memory_addr_bits);
+ SetCodeAddressMask(low_addr_mask);
+ SetDataAddressMask(low_addr_mask);
+ }
+
+ if (high_memory_addr_bits != 0) {
+ addr_t high_addr_mask =
+ AddressableBits::AddressableBitToMask(high_memory_addr_bits);
+ SetHighmemCodeAddressMask(high_addr_mask);
+ SetHighmemDataAddressMask(high_addr_mask);
+ }
+}
diff --git a/lldb/source/Utility/AddressableBits.cpp b/lldb/source/Utility/AddressableBits.cpp
index 7f9d7ec6c1349c..4c98addc1f073b 100644
--- a/lldb/source/Utility/AddressableBits.cpp
+++ b/lldb/source/Utility/AddressableBits.cpp
@@ -7,9 +7,10 @@
//===----------------------------------------------------------------------===//
#include "lldb/Utility/AddressableBits.h"
-#include "lldb/Target/Process.h"
#include "lldb/lldb-types.h"
+#include <cassert>
+
using namespace lldb;
using namespace lldb_private;
@@ -28,11 +29,19 @@ void AddressableBits::SetLowmemAddressableBits(
m_low_memory_addr_bits = lowmem_addressing_bits;
}
+uint32_t AddressableBits::GetLowmemAddressableBits() const {
+ return m_low_memory_addr_bits;
+}
+
void AddressableBits::SetHighmemAddressableBits(
uint32_t highmem_addressing_bits) {
m_high_memory_addr_bits = highmem_addressing_bits;
}
+uint32_t AddressableBits::GetHighmemAddressableBits() const {
+ return m_high_memory_addr_bits;
+}
+
addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
assert(addressable_bits <= sizeof(addr_t) * 8);
if (addressable_bits == 64)
@@ -40,20 +49,3 @@ addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
else
return ~((1ULL << addressable_bits) - 1);
}
-
-void AddressableBits::SetProcessMasks(Process &process) {
- if (m_low_memory_addr_bits == 0 && m_high_memory_addr_bits == 0)
- return;
-
- if (m_low_memory_addr_bits != 0) {
- addr_t low_addr_mask = AddressableBitToMask(m_low_memory_addr_bits);
- process.SetCodeAddressMask(low_addr_mask);
- process.SetDataAddressMask(low_addr_mask);
- }
-
- if (m_high_memory_addr_bits != 0) {
- addr_t hi_addr_mask = AddressableBitToMask(m_high_memory_addr_bits);
- process.SetHighmemCodeAddressMask(hi_addr_mask);
- process.SetHighmemDataAddressMask(hi_addr_mask);
- }
-}
|
jasonmolenda
approved these changes
Mar 19, 2024
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
…85858) AddressableBits is in the Utility module of LLDB. It currently directly refers to Process, which is from the Target LLDB module. This is a layering violation which concretely means that it is impossible to link anything that uses Utility without it also using Target as well. This is generally not an issue for LLDB (since everything is built together) but it may make it difficult to write unit tests for AddressableBits later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressableBits is in the Utility module of LLDB. It currently directly refers to Process, which is from the Target LLDB module. This is a layering violation which concretely means that it is impossible to link anything that uses Utility without it also using Target as well. This is generally not an issue for LLDB (since everything is built together) but it may make it difficult to write unit tests for AddressableBits later on.