[lldb] Remove process restart prompt from TestSourceManager #85861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TestSourceManager, test_artificial_source_location will give the process restart prompt if you run the test individually. The reason is that we run the process twice: first using a convenience function to run to a specific breakpoint and then again to check for a specific message emitted when you hit the breakpoint. Instead of running twice and making the test difficult to run individually, we can just check for the specific messages using other commands instead.
bulbazord
requested review from
medismailben
and removed request for
JDevlieghere
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesIn TestSourceManager, test_artificial_source_location will give the process restart prompt if you run the test individually. The reason is that we run the process twice: first using a convenience function to run to a specific breakpoint and then again to check for a specific message emitted when you hit the breakpoint. Instead of running twice and making the test difficult to run individually, we can just check for the specific messages using other commands. Full diff: https://github.com/llvm/llvm-project/pull/85861.diff 1 Files Affected:
diff --git a/lldb/test/API/source-manager/TestSourceManager.py b/lldb/test/API/source-manager/TestSourceManager.py
index eab8924d108146..896fec24791cd2 100644
--- a/lldb/test/API/source-manager/TestSourceManager.py
+++ b/lldb/test/API/source-manager/TestSourceManager.py
@@ -323,13 +323,13 @@ def test_artificial_source_location(self):
)
self.expect(
- "run",
- RUN_SUCCEEDED,
+ "thread info", substrs=[f"{src_file}:0", "stop reason = breakpoint"]
+ )
+ self.expect(
+ "frame select 0",
substrs=[
- "stop reason = breakpoint",
- "%s:%d" % (src_file, 0),
- "Note: this address is compiler-generated code in " "function",
- "that has no source code associated " "with it.",
+ "Note: this address is compiler-generated code in function",
+ "that has no source code associated with it.",
],
)
|
JDevlieghere
approved these changes
Mar 19, 2024
Comment on lines
325
to
332
| self.expect( | ||
| "run", | ||
| RUN_SUCCEEDED, | ||
| "thread info", substrs=[f"{src_file}:0", "stop reason = breakpoint"] | ||
| ) | ||
| self.expect( | ||
| "frame select 0", | ||
| substrs=[ | ||
| "stop reason = breakpoint", | ||
| "%s:%d" % (src_file, 0), | ||
| "Note: this address is compiler-generated code in " "function", | ||
| "that has no source code associated " "with it.", | ||
| "Note: this address is compiler-generated code in function", | ||
| "that has no source code associated with it.", |
There was a problem hiding this comment.
Can't this be a single process status command instead of both thread info & frame select 0 ?
There was a problem hiding this comment.
Just tried it out, it totally can be. Thanks for the tip!
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
In TestSourceManager, test_artificial_source_location will give the process restart prompt if you run the test individually. The reason is that we run the process twice: first using a convenience function to run to a specific breakpoint and then again to check for a specific message emitted when you hit the breakpoint. Instead of running twice and making the test difficult to run individually, we can just check for the specific messages using other commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TestSourceManager, test_artificial_source_location will give the process restart prompt if you run the test individually. The reason is that we run the process twice: first using a convenience function to run to a specific breakpoint and then again to check for a specific message emitted when you hit the breakpoint. Instead of running twice and making the test difficult to run individually, we can just check for the specific messages using other commands.