Skip to content

[mlir][bazel] Don't expose interface headers from //mlir:IR. #85867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

[mlir][bazel] Don't expose interface headers from //mlir:IR. #85867

merged 1 commit into from
Mar 21, 2024

Conversation

chsigg
Copy link
Contributor

@chsigg chsigg commented Mar 19, 2024 •
edited
Loading

Move 3 interface headers in //mlir:IR from hdrs to srcs.

Header files should not be added to multiple targets, but this is hard to avoid because CMake is less strict with headers. But we should at least avoid exposing them as headers by multiple targets because it confuses tooling.

@chsigg chsigg requested a review from rupprecht as a code owner March 19, 2024 21:12
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Mar 19, 2024
@chsigg chsigg requested a review from akuegel March 20, 2024 08:43
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 20, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
089b4e9 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 20, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
c734e89 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
@copybara-service copybara-service bot mentioned this pull request Mar 20, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 20, 2024
@chsigg @tensorflower-gardener
Explicitly depend on MLIR interface targets.
ba7446d 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
@copybara-service copybara-service bot mentioned this pull request Mar 20, 2024
Closed
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 20, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
9f3be3c 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 20, 2024
@chsigg @tensorflower-gardener
Explicitly depend on MLIR interface targets.
5a59a86 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 20, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
a2ec2ac 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 21, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
f5cab9f 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 21, 2024
@chsigg @tensorflower-gardener
Explicitly depend on MLIR interface targets.
e4ae2e5 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617287796
copybara-service bot pushed a commit to tensorflow/mlir-hlo that referenced this pull request Mar 21, 2024
@chsigg
Explicitly depend on MLIR interface targets.
f2695a8 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617781882
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Mar 21, 2024
@chsigg @copybara-github
Explicitly depend on MLIR interface targets.
e0f8035 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617781882
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 21, 2024
@chsigg @tensorflower-gardener
Explicitly depend on MLIR interface targets.
32048a9 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617781882
@chsigg chsigg merged commit 83e5a12 into llvm:main Mar 21, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
@chsigg @chencha3
[mlir][bazel] Don't expose interface headers from //mlir:IR. (llvm#85867
ed40efe 
)

Move 3 interface headers in `//mlir:IR` from `hdrs` to `srcs`.

Header files should not be added to multiple targets, but this is hard
to avoid because CMake is less strict with headers. But we should at
least avoid exposing them as headers by multiple targets because it
confuses tooling.
@chsigg chsigg deleted the piper_export_cl_617287796 branch March 26, 2024 14:02
steeve pushed a commit to zml/xla that referenced this pull request Aug 30, 2024
@chsigg @steeve
Explicitly depend on MLIR interface targets.
8d40607 
Preparation for llvm/llvm-project#85867.

PiperOrigin-RevId: 617781882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuegel akuegel akuegel approved these changes

@rupprecht rupprecht Awaiting requested review from rupprecht rupprecht is a code owner

Assignees
No one assigned
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chsigg @akuegel @llvmbot