-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[CodeGen][MRI] Introduce synthetic register classes #86006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ class MCRegisterClass { | |
const int8_t CopyCost; | ||
const bool Allocatable; | ||
const bool BaseClass; | ||
const bool Synthetic; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe those should be bitfields/a mask? |
||
|
||
/// getID() - Return the register class ID number. | ||
/// | ||
|
@@ -101,6 +102,9 @@ class MCRegisterClass { | |
|
||
/// Return true if this register class has a defined BaseClassOrder. | ||
bool isBaseClass() const { return BaseClass; } | ||
/// isSynthetic - Return true if this is a synthetic class. This field helps | ||
/// targets to dynamically enable the regclass during codegen. | ||
bool isSynthetic() const { return Synthetic; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reasoning for the "syntethic" name? I feel like "dynamic" suits it more, no? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to express a software constraint. Every other class is expressing a hardware constraint. We want to express a synthetic allocation window |
||
}; | ||
|
||
/// MCRegisterDesc - This record contains information about a particular | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be better named?
isEnabled
sounds very generic to just check synthetic info. PerhapsisSyntheticallyDisabled(RC)
?