[Libomptarget] Consolidate CPU offloading into 'host' directory #86014
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| if(NOT CMAKE_SYSTEM_NAME MATCHES "Linux") | ||
| return() | ||
| endif() | ||
|
|
||
| # build_generic_elf64("s390x" "S390X" "s390x" "systemz" "s390x-ibm-linux-gnu" "22") | ||
| # build_generic_elf64("aarch64" "aarch64" "aarch64" "aarch64" "aarch64-unknown-linux-gnu" "183") | ||
| # build_generic_elf64("ppc64" "PPC64" "ppc64" "ppc64" "powerpc64-ibm-linux-gnu" "21") | ||
| # build_generic_elf64("x86_64" "x86_64" "x86_64" "x86_64" "x86_64-pc-linux-gnu" "62") | ||
| # build_generic_elf64("ppc64le" "PPC64le" "ppc64" "ppc64le" "powerpc64le-ibm-linux-gnu" "21") | ||
| set(supported_targets x86_64 aarch64 ppc64 ppc64le s390x) | ||
| if(NOT ${CMAKE_SYSTEM_PROCESSOR} IN_LIST supported_targets) | ||
| libomptarget_say("Not building ${machine} NextGen offloading plugin") | ||
| return() | ||
| endif() | ||
|
|
||
| set(machine ${CMAKE_SYSTEM_PROCESSOR}) | ||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64le$") | ||
| set(machine ppc64) | ||
| endif() | ||
|
|
||
| add_llvm_library(omptarget.rtl.${machine} SHARED | ||
| src/rtl.cpp | ||
| ADDITIONAL_HEADER_DIRS | ||
| ${LIBOMPTARGET_INCLUDE_DIR} | ||
| LINK_LIBS PRIVATE | ||
| PluginCommon | ||
| ${OPENMP_PTHREAD_LIB} | ||
| NO_INSTALL_RPATH | ||
| BUILDTREE_ONLY | ||
| ) | ||
|
|
||
| if(LIBOMPTARGET_DEP_LIBFFI_FOUND) | ||
| libomptarget_say("Building ${machine} plugin linked with libffi") | ||
| if(FFI_STATIC_LIBRARIES) | ||
| target_link_libraries(omptarget.rtl.${machine} PRIVATE FFI::ffi_static) | ||
| else() | ||
| target_link_libraries(omptarget.rtl.${machine} PRIVATE FFI::ffi) | ||
| endif() | ||
| else() | ||
| libomptarget_say("Building ${machine} plugin for dlopened libffi") | ||
| target_sources(omptarget.rtl.${machine} PRIVATE dynamic_ffi/ffi.cpp) | ||
| target_include_directories(omptarget.rtl.${machine} PRIVATE dynamic_ffi) | ||
| endif() | ||
|
|
||
| if(OMPT_TARGET_DEFAULT AND LIBOMPTARGET_OMPT_SUPPORT) | ||
| target_link_libraries(omptarget.rtl.${machine} PRIVATE OMPT) | ||
| endif() | ||
|
|
||
| if(LIBOMP_HAVE_VERSION_SCRIPT_FLAG) | ||
| target_link_libraries(omptarget.rtl.${machine} PRIVATE | ||
| "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../exports") | ||
| endif() | ||
|
|
||
| # Install plugin under the lib destination folder. | ||
| install(TARGETS omptarget.rtl.${machine} | ||
| LIBRARY DESTINATION "${OPENMP_INSTALL_LIBDIR}") | ||
| set_target_properties(omptarget.rtl.${machine} PROPERTIES | ||
| INSTALL_RPATH "$ORIGIN" BUILD_RPATH "$ORIGIN:${CMAKE_CURRENT_BINARY_DIR}/.." | ||
| POSITION_INDEPENDENT_CODE ON | ||
| CXX_VISIBILITY_PRESET protected) | ||
|
|
||
| target_include_directories(omptarget.rtl.${machine} PRIVATE | ||
| ${LIBOMPTARGET_INCLUDE_DIR}) | ||
|
|
||
| if(LIBOMPTARGET_DEP_LIBFFI_FOUND) | ||
| list(APPEND LIBOMPTARGET_TESTED_PLUGINS omptarget.rtl.${machine}) | ||
| set(LIBOMPTARGET_TESTED_PLUGINS | ||
| "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE) | ||
| else() | ||
| libomptarget_say("Not generating ${tmachine_name} tests. LibFFI not found.") | ||
| endif() | ||
|
|
||
| # Define macro to be used as prefix of the runtime messages for this target. | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE TARGET_NAME=${machine}) | ||
| # TODO: This should be automatized in Debug.h. | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE | ||
| DEBUG_PREFIX="TARGET ${machine} RTL") | ||
|
|
||
| # Define the target specific triples and ELF machine values. | ||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64le$" OR | ||
| CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64$") | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE TARGET_ELF_ID=EM_PPC64) | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE | ||
| LIBOMPTARGET_NEXTGEN_GENERIC_PLUGIN_TRIPLE="powerpc64-ibm-linux-gnu") | ||
| list(APPEND LIBOMPTARGET_SYSTEM_TARGETS | ||
| "powerpc64-ibm-linux-gnu" "powerpc64-ibm-linux-gnu-LTO") | ||
| set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS}" PARENT_SCOPE) | ||
| elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64$") | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE TARGET_ELF_ID=EM_X86_64) | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE | ||
| LIBOMPTARGET_NEXTGEN_GENERIC_PLUGIN_TRIPLE="x86_64-pc-linux-gnu") | ||
| list(APPEND LIBOMPTARGET_SYSTEM_TARGETS | ||
| "x86_64-pc-linux-gnu" "x86_64-pc-linux-gnu-LTO") | ||
| set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS}" PARENT_SCOPE) | ||
| elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64$") | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE TARGET_ELF_ID=EM_AARCH64) | ||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE | ||
| LIBOMPTARGET_NEXTGEN_GENERIC_PLUGIN_TRIPLE="aarch64-unknown-linux-gnu") | ||
| list(APPEND LIBOMPTARGET_SYSTEM_TARGETS | ||
| "aarch64-unknown-linux-gnu" "aarch64-unknown-linux-gnu-LTO") | ||
| set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS}" PARENT_SCOPE) | ||
| elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "s390x$") | ||
| target_compile_definitions(omptarget.rtl.${machine} TARGET_ELF_ID=EM_S390) | ||
|
There was a problem hiding this comment. There's a missing "PRIVATE" on this line, which caused the build to break on SystemZ. Fixed in cb07194. |
||
| target_compile_definitions(omptarget.rtl.${machine} PRIVATE | ||
| LIBOMPTARGET_NEXTGEN_GENERIC_PLUGIN_TRIPLE="s390x-ibm-linux-gnu") | ||
| list(APPEND LIBOMPTARGET_SYSTEM_TARGETS | ||
| "s390x-ibm-linux-gnu" "s390x-ibm-linux-gnu-LTO") | ||
| set(LIBOMPTARGET_SYSTEM_TARGETS "${LIBOMPTARGET_SYSTEM_TARGETS}" PARENT_SCOPE) | ||
| endif() | ||
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, because it is specifying a big-endian triple (powerpc64-ibm-linux-gnu) when the host is little-endian (ppc64le). The ppc64le and ppc64 $CMAKE_SYSTEM_PROCESSOR values need to be handled separately.
cc @tuliom
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tstellar Agreed. It's worth mentioning that using
powerpc64lein triples is more frequent thanppc64le.This is the first time I see
-ibmbeing used for appc64*-linuxsystem.Is the usage of
-ibmreally necessary? And what it means?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made #88773. Using the vendor field doesn't really do anything for these triples. It's the same as
x86_64-pc-linux-gnuwhich doesn't make a difference except for runtime directory stuff.