Skip to content

[BOLT] Add number of basic blocks to BAT #86045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Mar 20, 2024

YAML profile reader checks the number of basic blocks in regular,
no-stale-matching mode. Add it to BAT.

This increases the size of BAT section to:

  • large binary: 39583080 bytes (1.02x of the original),
  • medium binary: 3816492 bytes (0.64x),
  • small binary: 920 bytes (0.64x, no change due to alignment).

Test Plan: Updated bolt-address-translation-yaml.test

aaupov added 2 commits March 20, 2024 16:52
Created using spr 1.3.4
aaupov added 4 commits March 20, 2024 17:08
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Copy link
Contributor

@rafaelauler rafaelauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-add-number-of-basic-blocks-to-bat to main March 22, 2024 13:07
@aaupov aaupov changed the base branch from main to users/aaupov/spr/main.bolt-add-number-of-basic-blocks-to-bat March 22, 2024 14:42
@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-add-number-of-basic-blocks-to-bat to main March 22, 2024 15:45
Created using spr 1.3.4
@aaupov aaupov merged commit ceba3a3 into main Mar 22, 2024
@aaupov aaupov deleted the users/aaupov/spr/bolt-add-number-of-basic-blocks-to-bat branch March 22, 2024 15:46
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
YAML profile reader checks the number of basic blocks in regular,
no-stale-matching mode. Add it to BAT.

This increases the size of BAT section to:
- large binary: 39583080 bytes (1.02x of the original),
- medium binary: 3816492 bytes (0.64x),
- small binary: 920 bytes (0.64x, no change due to alignment).

Test Plan: Updated bolt-address-translation-yaml.test

Reviewers: rafaelauler, ayermolo, maksfb, dcci

Reviewed By: rafaelauler

Pull Request: llvm#86045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants