Skip to content

[LLVM][TextAPI] Refactor Redundant Condition #86542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2024
Merged

[LLVM][TextAPI] Refactor Redundant Condition #86542

merged 4 commits into from
Apr 19, 2024

Conversation

Troy-Butler
Copy link
Contributor

@Troy-Butler Troy-Butler commented Mar 25, 2024

Fixes #83241

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@cyndyishida
Copy link
Member

The change looks good to me, thanks!
Though the commit line shows [LIB], what is that short for? llvm/lib? library?
Please update it to [TextAPI] instead.

@Troy-Butler Troy-Butler changed the title [LLVM][LIB] Refactor Redundant Condition [LLVM][TextAPI] Refactor Redundant Condition Mar 25, 2024
@Troy-Butler Troy-Butler requested a review from cyndyishida March 25, 2024 18:03
@RKSimon
Copy link
Collaborator

RKSimon commented Apr 19, 2024

@cyndyishida I don't think @Troy-Butler has commit rights - please can you commit?

@cyndyishida cyndyishida merged commit e6e9319 into llvm:main Apr 19, 2024
Copy link

@Troy-Butler Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

aniplcc pushed a commit to aniplcc/llvm-project that referenced this pull request Apr 21, 2024
Fixes llvm#83241

---------

Signed-off-by: Troy-Butler <[email protected]>
Co-authored-by: Troy-Butler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm/lib/TextAPI/TextStub.cpp: 2 * redundant condition ?
3 participants