Skip to content

[bazel] Fix minor buildifier warnings (NFC) #86566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[bazel] Fix minor buildifier warnings (NFC) #86566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,15 +623,15 @@ cc_library(
srcs = [
"utils/TableGen/Common/GlobalISel/CodeExpander.cpp",
],
hdrs = glob([
hdrs = [
# We have to include these headers here as well as in the `hdrs` below
# to allow the `.cpp` files to use file-relative-inclusion to find
# them, even though consumers of this library use inclusion relative to
# `utils/TableGen` with the `strip_includes_prefix` of this library.
# This mixture appears to be incompatible with header modules.
"utils/TableGen/Common/GlobalISel/CodeExpander.h",
"utils/TableGen/Common/GlobalISel/CodeExpansions.h",
]),
],
copts = llvm_copts,
features = ["-header_modules"],
strip_include_prefix = "utils/TableGen",
Expand Down Expand Up @@ -665,10 +665,11 @@ cc_binary(
# listed here. MC uses headers produced by tablegen, so it cannot be a
# regular dependency.
"include/llvm/MC/*.h",
"include/llvm/TargetParser/SubtargetFeature.h",
],
exclude = ["utils/TableGen/Common/GlobalISel/CodeExpander.cpp"],
),
) + [
"include/llvm/TargetParser/SubtargetFeature.h",
],
copts = llvm_copts,
includes = ["utils/TableGen"],
stamp = 0,
Expand Down
5 changes: 3 additions & 2 deletions utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,10 +357,11 @@ cc_test(
[
"IR/*.cpp",
"IR/*.h",
"Support/KnownBitsTest.h",
],
allow_empty = False,
),
) + [
"Support/KnownBitsTest.h",
],
shard_count = 20,
deps = [
"//llvm:Analysis",
Expand Down
2 changes: 1 addition & 1 deletion utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8197,8 +8197,8 @@ cc_library(
deps = [
":ConversionPassIncGen",
":EmitCDialect",
":MemRefDialect",
":IR",
":MemRefDialect",
":Pass",
":Support",
":TransformUtils",
Expand Down