Fix failing tests after #86242 #86572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#86242 introduced a copy-paste error that caused some tests to fail by mapping the wrong pass name to a pass. This resolves the issue and fixes the failing tests.
|
@llvm/pr-subscribers-backend-directx Author: Chris B (llvm-beanz) ChangesPR #86242 introduced a copy-paste error that caused some tests to fail by mapping the wrong pass name to a pass. This resolves the issue and fixes the failing tests. Full diff: https://github.com/llvm/llvm-project/pull/86572.diff 1 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DirectXPassRegistry.def b/llvm/lib/Target/DirectX/DirectXPassRegistry.def
index bbf0c254bb697f..1b326d020d5114 100644
--- a/llvm/lib/Target/DirectX/DirectXPassRegistry.def
+++ b/llvm/lib/Target/DirectX/DirectXPassRegistry.def
@@ -24,6 +24,6 @@ MODULE_ANALYSIS("dxil-resource", DXILResourceAnalysis())
#define MODULE_PASS(NAME, CREATE_PASS)
#endif
// TODO: rename to print<foo> after NPM switch
-MODULE_PASS("print-dx-shader-flags", DXILResourcePrinterPass(dbgs()))
+MODULE_PASS("print-dx-shader-flags", dxil::ShaderFlagsAnalysisPrinter(dbgs()))
MODULE_PASS("print-dxil-resource", DXILResourcePrinterPass(dbgs()))
#undef MODULE_PASS
|
farzonl
approved these changes
Mar 25, 2024
bogner
approved these changes
Mar 25, 2024
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
✅ With the latest revision this PR passed the Python code formatter. |
coopp
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #86242 introduced a copy-paste error that caused some tests to fail by mapping the wrong pass name to a pass. This resolves the issue and fixes the failing tests.