Skip to content

[lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES #86962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES #86962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions lldb/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,6 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
endforeach()
endif()

# The "pexpect" package should come from the system environment, not from the
# LLDB tree. However, we delay the deletion of it from the tree in case
# users/buildbots don't have the package yet and need some time to install it.
# Windows is configured to skip all pexpect tests, and guards all
# "import pexpect" calls, so we do not need pexpect installed there.
if (NOT LLDB_TEST_USE_VENDOR_PACKAGES AND NOT WIN32)
unset(PY_pexpect_FOUND CACHE)
lldb_find_python_module(pexpect)
if (NOT PY_pexpect_FOUND)
message(FATAL_ERROR
"Python module 'pexpect' not found. Please install it via pip or via "
"your operating system's package manager. For a temporary workaround, "
"use a version from the LLDB tree with "
"`LLDB_TEST_USE_VENDOR_PACKAGES=ON`")
endif()
endif()

if(LLDB_BUILT_STANDALONE)
# In order to run check-lldb-* we need the correct map_config directives in
# llvm-lit. Because this is a standalone build, LLVM doesn't know about LLDB,
Expand Down