Skip to content

[clang][Darwin] Handle reexported library arguments in driver #86980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[clang][Darwin] Handle reexported library arguments in driver #86980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/include/clang/Driver/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3635,6 +3635,9 @@ defm preserve_as_comments : BoolFOption<"preserve-as-comments",
"Do not preserve comments in inline assembly">,
PosFlag<SetTrue>>;
def framework : Separate<["-"], "framework">, Flags<[LinkerInput]>;
def reexport_framework : Separate<["-"], "reexport_framework">, Flags<[LinkerInput]>;
def reexport_l : Joined<["-"], "reexport-l">, Flags<[LinkerInput]>;
def reexport_library : JoinedOrSeparate<["-"], "reexport_library">, Flags<[LinkerInput]>;
def frandom_seed_EQ : Joined<["-"], "frandom-seed=">, Group<clang_ignored_f_Group>;
def freg_struct_return : Flag<["-"], "freg-struct-return">, Group<f_Group>,
Visibility<[ClangOption, CC1Option]>,
Expand Down
21 changes: 21 additions & 0 deletions clang/test/Driver/darwin-ld-reexports.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// RUN: touch %t.o
// RUN: %clang -target arm64-apple-darwin13 -### \
// RUN: -reexport_framework Foo -reexport-lBar -reexport_library Baz %t.o 2> %t.log

// Check older spellings also work.
// RUN: %clang -target arm64-apple-darwin13 -### \
// RUN: -Xlinker -reexport_framework -Xlinker Forest \
// RUN: -Xlinker -reexport-lBranch \
// RUN: -Xlinker -reexport_library -Xlinker Flower %t.o 2>> %t.log
// RUN: FileCheck -check-prefix=LINK_REEXPORT %s < %t.log

// LINK_REEXPORT: {{ld(.exe)?"}}
// LINK_REEXPORT: "-reexport_framework" "Foo"
// LINK_REEXPORT: "-reexport-lBar"
// LINK_REEXPORT: "-reexport_library" "Baz"
// LINK_REEXPORT: "-reexport_framework" "Forest"
// LINK_REEXPORT: "-reexport-lBranch"
// LINK_REEXPORT: "-reexport_library" "Flower"

// Make sure arguments are not repeated.
// LINK_REEXPORT-NOT: "-reexport