[BOLT] Don't terminate on trap instruction for Linux kernel #87021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under normal circumstances, we terminate basic blocks on a trap instruction. However, Linux kernel may resume execution after hitting a trap (ud2 on x86). Thus, we introduce "--terminal-trap" option that will specify if the trap instruction should terminate the control flow. The option is on by default except for the Linux kernel mode when it's off.
maksfb
requested review from
aaupov,
rafaelauler,
ayermolo and
dcci
as code owners
aaupov
approved these changes
Mar 28, 2024
Comment on lines
-217
to
-218
| return Info->get(Opcode).isTerminator() || X86::isUD1(Opcode) || | ||
| X86::isUD2(Opcode); |
There was a problem hiding this comment.
Assuming you tested that it's safe to drop ud1/ud2 from terminators.
There was a problem hiding this comment.
I'm dropping them only for the Linux kernel. For the rest, by default they will still terminate, but the condition check is modified with isTrap() check instead of the opcode lookup.
dcci
approved these changes
Mar 29, 2024
maksfb
commented
Mar 29, 2024
| @@ -121,6 +130,11 @@ bool MCPlusBuilder::equals(const MCTargetExpr &A, const MCTargetExpr &B, | |||
| llvm_unreachable("target-specific expressions are unsupported"); | |||
| } | |||
|
|
|||
| bool MCPlusBuilder::isTerminator(const MCInst &Inst) const { | |||
| return Analysis->isTerminator(Inst) || | |||
| (opts::TerminalTrap && Info->get(Inst.getOpcode()).isTrap()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under normal circumstances, we terminate basic blocks on a trap instruction. However, Linux kernel may resume execution after hitting a trap (ud2 on x86). Thus, we introduce "--terminal-trap" option that will specify if the trap instruction should terminate the control flow. The option is on by default except for the Linux kernel mode when it's off.