Skip to content

[TableGen][NFC] Add maybe_unused to MRI #87044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

[TableGen][NFC] Add maybe_unused to MRI #87044

merged 1 commit into from
Apr 1, 2024

Conversation

wangpc-pp
Copy link
Contributor

This suppresses warning unused variable 'MRI' [-Wunused-variable]
for those fusions that don't need MRI.

@wangpc-pp
[TableGen][NFC] Add maybe_unused to MRI
115a77a 
This suppresses warning `unused variable 'MRI' [-Wunused-variable]`
for those fusions that don't need `MRI`.
@wangpc-pp wangpc-pp requested a review from arsenm March 29, 2024 08:26
arsenm
arsenm approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a parameter to these generated functions instead?

@wangpc-pp
Copy link
Contributor Author

Maybe this should be a parameter to these generated functions instead?

That will change the signature of MacroFusionPredTy, which is too invasive I think.

@wangpc-pp wangpc-pp merged commit b342d87 into llvm:main Apr 1, 2024
@wangpc-pp wangpc-pp deleted the main-tablegen-macrofusion-unused branch April 1, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsenm arsenm arsenm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangpc-pp @arsenm