Skip to content

[flang][OpenMP] Move clause/object conversion to happen early, in genOMP #87086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 18, 2024
Merged

[flang][OpenMP] Move clause/object conversion to happen early, in genOMP #87086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9ee93f
[MLIR][OpenMP] Group clause operands into structures
skatrak Mar 26, 2024
7af7e9d
[Flang][OpenMP][Lower] Use clause operand structures
skatrak Mar 26, 2024
e291fad
[Flang][OpenMP][Lower] Split MLIR codegen for clauses and constructs
skatrak Mar 28, 2024
d56c859
Merge branch 'main' into users/skatrak/spr/clause-operands-01-mlir
skatrak Mar 28, 2024
3d9ec39
Merge branch 'users/skatrak/spr/clause-operands-01-mlir' into users/s…
skatrak Mar 28, 2024
0416ec4
Merge branch 'users/skatrak/spr/clause-operands-02-flang' into users/…
skatrak Mar 28, 2024
ec0ed50
[Flang][OpenMP][Lower] Refactor lowering of compound constructs
skatrak Mar 29, 2024
46770f8
[flang][OpenMP] Move clause/object conversion to happen early, in genOMP
kparzysz Mar 29, 2024
de93771
Merge branch 'main' into users/kparzysz/spr/a05-makeclause
kparzysz Apr 17, 2024
065b54c
clang-format
kparzysz Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions flang/lib/Lower/OpenMP/ClauseProcessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ class ClauseProcessor {
public:
ClauseProcessor(Fortran::lower::AbstractConverter &converter,
Fortran::semantics::SemanticsContext &semaCtx,
const Fortran::parser::OmpClauseList &clauses)
: converter(converter), semaCtx(semaCtx),
clauses(makeClauses(clauses, semaCtx)) {}
const List<Clause> &clauses)
: converter(converter), semaCtx(semaCtx), clauses(clauses) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the clauses field an ArrayRef<Clause>? In the regular use pattern of this class the clause list of the caller does not go out of scope before the ClauseProcessor instance does. Maybe we can document this and avoid creating a local copy.

In any case this is a discussion to consider creating another patch for, not something to be addressed here.


// 'Unique' clauses: They can appear at most once in the clause list.
bool processCollapse(
Expand Down
5 changes: 2 additions & 3 deletions flang/lib/Lower/OpenMP/DataSharingProcessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,12 @@ class DataSharingProcessor {
public:
DataSharingProcessor(Fortran::lower::AbstractConverter &converter,
Fortran::semantics::SemanticsContext &semaCtx,
const Fortran::parser::OmpClauseList &opClauseList,
const List<Clause> &clauses,
Fortran::lower::pft::Evaluation &eval,
bool useDelayedPrivatization = false,
Fortran::lower::SymMap *symTable = nullptr)
: hasLastPrivateOp(false), converter(converter),
firOpBuilder(converter.getFirOpBuilder()),
clauses(omp::makeClauses(opClauseList, semaCtx)), eval(eval),
firOpBuilder(converter.getFirOpBuilder()), clauses(clauses), eval(eval),
useDelayedPrivatization(useDelayedPrivatization), symTable(symTable) {}

// Privatisation is split into two steps.
Expand Down
Loading