Skip to content

lit_test : check if there is already a deps key in kwargs #87290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

lit_test : check if there is already a deps key in kwargs #87290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b33d98
check if there is already a deps key in kwargs
abhigunj Apr 1, 2024
43971db
addressed review comment
abhigunj Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion utils/bazel/llvm-project-overlay/llvm/lit_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def lit_test(
srcs,
args = None,
data = None,
deps = None,
**kwargs):
"""Runs a single test file with LLVM's lit tool.

Expand All @@ -27,6 +28,7 @@ def lit_test(

args = args or []
data = data or []
deps = deps or []

native.py_test(
name = name,
Expand All @@ -35,7 +37,7 @@ def lit_test(
args = args + ["-v"] + ["$(execpath %s)" % src for src in srcs],
data = data + srcs,
legacy_create_init = False,
deps = [Label("//llvm:lit")],
deps = deps + [Label("//llvm:lit")],
**kwargs
)

Expand Down