Skip to content

[SystemZ][z/OS] Remove COMPILER_IBMXL macro for z/OS #87493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

fanbo-meng
Copy link
Contributor

This copies the change made in google benchmark (google/benchmark@70916cb) to remove COMPILER_IBMXL for z/OS.

Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This copies the change made in google benchmark (google/benchmark@70916cb) to remove COMPILER_IBMXL for z/OS.
@fanbo-meng fanbo-meng merged commit 4d34b32 into llvm:main Apr 3, 2024
@fanbo-meng fanbo-meng deleted the fm-remove-macro branch April 3, 2024 13:45
@llvmbot
Copy link
Member

llvmbot commented Apr 3, 2024

@llvm/pr-subscribers-third-party-benchmark

Author: Fanbo Meng (fanbo-meng)

Changes

This copies the change made in google benchmark (google/benchmark@70916cb) to remove COMPILER_IBMXL for z/OS.


Full diff: https://github.com/llvm/llvm-project/pull/87493.diff

2 Files Affected:

  • (modified) third-party/benchmark/src/cycleclock.h (+3-2)
  • (modified) third-party/benchmark/src/internal_macros.h (+1-5)
diff --git a/third-party/benchmark/src/cycleclock.h b/third-party/benchmark/src/cycleclock.h
index eff563e7fac223..d4f1330b671db9 100644
--- a/third-party/benchmark/src/cycleclock.h
+++ b/third-party/benchmark/src/cycleclock.h
@@ -181,10 +181,11 @@ inline BENCHMARK_ALWAYS_INLINE int64_t Now() {
 #elif defined(__s390__)  // Covers both s390 and s390x.
   // Return the CPU clock.
   uint64_t tsc;
-#if defined(BENCHMARK_OS_ZOS) && defined(COMPILER_IBMXL)
-  // z/OS XL compiler HLASM syntax.
+#if defined(BENCHMARK_OS_ZOS)
+  // z/OS HLASM syntax.
   asm(" stck %0" : "=m"(tsc) : : "cc");
 #else
+  // Linux on Z syntax.
   asm("stck %0" : "=Q"(tsc) : : "cc");
 #endif
   return tsc;
diff --git a/third-party/benchmark/src/internal_macros.h b/third-party/benchmark/src/internal_macros.h
index 8dd7d0c6502e86..f4894ba8e65d62 100644
--- a/third-party/benchmark/src/internal_macros.h
+++ b/third-party/benchmark/src/internal_macros.h
@@ -11,11 +11,7 @@
 #endif
 
 #if defined(__clang__)
-  #if defined(__ibmxl__)
-    #if !defined(COMPILER_IBMXL)
-      #define COMPILER_IBMXL
-    #endif
-  #elif !defined(COMPILER_CLANG)
+  #if !defined(COMPILER_CLANG)
     #define COMPILER_CLANG
   #endif
 #elif defined(_MSC_VER)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants