[Flang] Make SLES 15 build tests #87498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLES 15 SP4 comes with a GCC 7.5 as default, which does not support the C++17 <charconv> header. This results in build errors when trying to run check-flang. This patch addresses that and uses the older std::stol for the string -> number conversion to allow the SLES 15 buildbot to succeed.
klausler
approved these changes
Apr 3, 2024
|
It was brought up internally to try to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLES 15 comes with a GCC 7.5 as default, which does not support the C++17
<charconv>header. This results in build errors when trying to runcheck-flang.This patch addresses that and uses the older
std::stolfor the string -> number conversion to allow the SLES 15 buildbot (https://lab.llvm.org/staging/#/builders/193) to turn green.