[mlir] Initialize DefaultTimingManager::out.

[wecing]

DefaultTimingManager::clear() uses out to initialize TimerImpl, but the out is nullptr by default. This means if DefaultTimingManager::setOutput() is never called, DefaultTimingManager destructor may generate SIGSEGV.

[llvmbot]

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Chenguang Wang (wecing)

Changes

DefaultTimingManager::clear() uses out to initialize TimerImpl, but the out is nullptr by default. This means if DefaultTimingManager::setOutput() is never called, DefaultTimingManager destructor may generate SIGSEGV.

---

Full diff: https://github.com/llvm/llvm-project/pull/87522.diff

1 Files Affected:

• (modified) mlir/lib/Support/Timing.cpp (+2-1)

diff --git a/mlir/lib/Support/Timing.cpp b/mlir/lib/Support/Timing.cpp
index 1d6796e9d8dc50..ac16eb7d224c9a 100644
--- a/mlir/lib/Support/Timing.cpp
+++ b/mlir/lib/Support/Timing.cpp
@@ -499,7 +499,8 @@ class DefaultTimingManagerImpl {
 } // namespace mlir
 
 DefaultTimingManager::DefaultTimingManager()
-    : impl(std::make_unique<DefaultTimingManagerImpl>()) {
+    : impl(std::make_unique<DefaultTimingManagerImpl>()),
+      out(std::make_unique<OutputTextStrategy>(llvm::errs())) {
   clear(); // initializes the root timer
 }