[BOLT][BAT] Fix handling of split functions #87569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
maksfb
reviewed
Apr 10, 2024
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
maksfb
approved these changes
Apr 11, 2024
aaupov
changed the base branch from
users/aaupov/spr/main.boltbat-fix-handling-of-split-functions
to
main
aaupov
deleted the
users/aaupov/spr/boltbat-fix-handling-of-split-functions
branch
aaupov
added a commit
that referenced
this pull request
Apr 11, 2024
Call site information setting was conditioned on branch information presence for a given block. However, it's possible to have sampled profile lacking one or the other for a given basic block. Iterate over branch profiles and call profiles independently to cover all recorded profile data. Depends on #87569 Test Plan: Updated bolt/test/X86/yaml-secondary-entry-discriminator.s Reviewers: ayermolo, dcci, maksfb, rafaelauler Reviewed By: maksfb Pull Request: #87743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move BAT parent function lookup outside
getLocationName, to thescope where we retrieve
FuncBranchDatalinked with the function.Previously DataAggregator would store branch profile recorded in the
split fragment in
FuncBranchDataassociated with the fragment, andperform name translation in
getLocationNamefor symbol name only.This works for fdata profile which is printed out as-is, but doesn't
work with BAT YAML profile writer which requires a combined profile.
The issue necessitated
fixupBATProfilewhich partially addressed theissue (reassigned inter-fragment calls back into intra-function
branches). However,
fixupBATProfilefails to address disjointprofiles (i.e. doesn't merge
FuncBranchDatafor fragments backinto parent). This diff eliminates the need for
fixupBATProfilebyremoving the root cause of the issue.
Test Plan: NFC for existing tests