Skip to content

[ValueTracking] Add support for xor/disjoint or in getInvertibleOperands #87705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ValueTracking] Add support for xor/disjoint or in getInvertibleOperands #87705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c77b2c6
[ValueTracking] Add tests for `xor`/`disjoint or` in `getInvertibleOp…
goldsteinn Apr 4, 2024
56c6ff8
[ValueTracking] Add support for `xor`/`disjoint or` in `getInvertible…
goldsteinn Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion llvm/lib/Analysis/ValueTracking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3004,7 +3004,20 @@ getInvertibleOperands(const Operator *Op1,
switch (Op1->getOpcode()) {
default:
break;
case Instruction::Add:
case Instruction::Or:
if (!cast<PossiblyDisjointInst>(Op1)->isDisjoint() ||
!cast<PossiblyDisjointInst>(Op2)->isDisjoint())
break;
[[fallthrough]];
case Instruction::Xor:
case Instruction::Add: {
Value *Other;
if (match(Op2, m_c_BinOp(m_Specific(Op1->getOperand(0)), m_Value(Other))))
return std::make_pair(Op1->getOperand(1), Other);
if (match(Op2, m_c_BinOp(m_Specific(Op1->getOperand(1)), m_Value(Other))))
return std::make_pair(Op1->getOperand(0), Other);
break;
}
case Instruction::Sub:
if (Op1->getOperand(0) == Op2->getOperand(0))
return getOperands(1);
Expand Down
80 changes: 79 additions & 1 deletion llvm/test/Transforms/InstSimplify/icmp.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,11 +270,89 @@ define i1 @load_ptr(ptr %p) {

define i1 @load_ptr_null_valid(ptr %p) null_pointer_is_valid {
; CHECK-LABEL: @load_ptr_null_valid(
; CHECK-NEXT: [[LOAD_P:%.*]] = load ptr, ptr [[P:%.*]], align 8, !dereferenceable !0
; CHECK-NEXT: [[LOAD_P:%.*]] = load ptr, ptr [[P:%.*]], align 8, !dereferenceable [[META0:![0-9]+]]
; CHECK-NEXT: [[R:%.*]] = icmp ne ptr [[LOAD_P]], null
; CHECK-NEXT: ret i1 [[R]]
;
%load_p = load ptr, ptr %p, !dereferenceable !{i64 8}
%r = icmp ne ptr %load_p, null
ret i1 %r
}

define i1 @non_eq_disjoint_or_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_disjoint_or_common_op(
; CHECK-NEXT: ret i1 false
;
%w = add nuw i8 %ww, 1
%z = add i8 %y, %w

%xy = or disjoint i8 %x, %y
%xz = or disjoint i8 %x, %z

%axy = add i8 %a, %xy
%axz = add i8 %a, %xz
%r = icmp eq i8 %axy, %axz
ret i1 %r
}

define i1 @non_eq_disjoint_or_common_op_fail(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_disjoint_or_common_op_fail(
; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
; CHECK-NEXT: [[XY:%.*]] = or i8 [[X:%.*]], [[Y]]
; CHECK-NEXT: [[XZ:%.*]] = or disjoint i8 [[X]], [[Z]]
; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
; CHECK-NEXT: ret i1 [[R]]
;
%w = add nuw i8 %ww, 1
%z = add i8 %y, %w

%xy = or i8 %x, %y
%xz = or disjoint i8 %x, %z

%axy = add i8 %a, %xy
%axz = add i8 %a, %xz
%r = icmp eq i8 %axy, %axz
ret i1 %r
}

define i1 @non_eq_xor_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_xor_common_op(
; CHECK-NEXT: ret i1 false
;
%w = add nuw i8 %ww, 1
%z = add i8 %y, %w

%xy = xor i8 %y, %x
%xz = xor i8 %x, %z

%axy = add i8 %a, %xy
%axz = add i8 %a, %xz
%r = icmp eq i8 %axy, %axz
ret i1 %r
}

define i1 @non_eq_xor_common_op_fail(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_xor_common_op_fail(
; CHECK-NEXT: [[W:%.*]] = add nsw i8 [[WW:%.*]], 1
; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
; CHECK-NEXT: [[XY:%.*]] = xor i8 [[Y]], [[X:%.*]]
; CHECK-NEXT: [[XZ:%.*]] = xor i8 [[X]], [[Z]]
; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
; CHECK-NEXT: ret i1 [[R]]
;
%w = add nsw i8 %ww, 1
%z = add i8 %y, %w

%xy = xor i8 %y, %x
%xz = xor i8 %x, %z

%axy = add i8 %a, %xy
%axz = add i8 %a, %xz
%r = icmp eq i8 %axy, %axz
ret i1 %r
}