Skip to content

[zOS] Turn CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zOS #87797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

bahareh-farhadi
Copy link
Contributor

@bahareh-farhadi bahareh-farhadi commented Apr 5, 2024

PR #84461 disabled clang/unittests/Interpreter/InterpreterExtensionsTest.cpp for AIX by turning on CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT.
This PR turns CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zOS as well, since LLJIT cannot be created on zOS either.

Copy link

github-actions bot commented Apr 5, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@bahareh-farhadi bahareh-farhadi changed the title Turn CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zos as well [zOS] Turn CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zos as well Apr 5, 2024
@bahareh-farhadi bahareh-farhadi changed the title [zOS] Turn CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zos as well [zOS] Turn CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zOS Apr 5, 2024
@bahareh-farhadi bahareh-farhadi marked this pull request as ready for review April 8, 2024 12:23
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Apr 8, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 8, 2024

@llvm/pr-subscribers-clang

Author: None (bahareh-farhadi)

Changes

PR #84461 disabled clang/unittests/Interpreter/InterpreterExtensionsTest.cpp for AIX by turning on CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT.
This PR turns CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT on for zOS as well, since LLJIT cannot be created on zOS either.


Full diff: https://github.com/llvm/llvm-project/pull/87797.diff

1 Files Affected:

  • (modified) clang/unittests/Interpreter/InterpreterExtensionsTest.cpp (+1-1)
diff --git a/clang/unittests/Interpreter/InterpreterExtensionsTest.cpp b/clang/unittests/Interpreter/InterpreterExtensionsTest.cpp
index 1ba865a79ed778..b971cd550dc507 100644
--- a/clang/unittests/Interpreter/InterpreterExtensionsTest.cpp
+++ b/clang/unittests/Interpreter/InterpreterExtensionsTest.cpp
@@ -30,7 +30,7 @@
 
 #include <system_error>
 
-#if defined(_AIX)
+#if defined(_AIX) || defined(__MVS__)
 #define CLANG_INTERPRETER_PLATFORM_CANNOT_CREATE_LLJIT
 #endif
 

Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhina-sree abhina-sree merged commit 8c6e045 into llvm:main Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

@bahareh-farhadi Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants